starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1141] [MERGED] [WIP] Address feedback on async creation cleanup changes #1579

New Issue
Closed
opened 2026-01-29 22:21:13 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:21:13 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1141
Author: @Copilot
Created: 1/16/2026
Status: ✅ Merged
Merged: 1/16/2026
Merged by: @adamhathcock

Base: adam/async-creation ← Head: copilot/sub-pr-1132

📝 Commits (4)

  • 4b34dd6 Initial plan
  • 6e5e47f Update SevenZipFactory to consistently call OpenAsyncArchive methods
  • 2180df3 Pass CancellationToken.None explicitly to OpenAsyncArchive methods
  • cfe59fc Merge branch 'adam/async-creation' into copilot/sub-pr-1132

📊 Changes

1 file changed (+4 additions, -8 deletions)

View changed files

📝 src/SharpCompress/Factories/SevenZipFactory.cs (+4 -8)

📄 Description

  • Understand the current async architecture in SevenZipArchive
  • Identify the issue with OpenAsyncArchive methods in SevenZipFactory
  • Update SevenZipFactory.OpenAsyncArchive methods to call SevenZipArchive.OpenAsyncArchive instead of casting sync OpenArchive
  • Ensure cancellation tokens are passed through where available
  • Test the changes
  • Run code review and address feedback
  • Run security scan

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1141 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 1/16/2026 **Status:** ✅ Merged **Merged:** 1/16/2026 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `adam/async-creation` ← **Head:** `copilot/sub-pr-1132` --- ### 📝 Commits (4) - [`4b34dd6`](https://github.com/adamhathcock/sharpcompress/commit/4b34dd61d38623dd551313205d711e1552483917) Initial plan - [`6e5e47f`](https://github.com/adamhathcock/sharpcompress/commit/6e5e47f041158449fd00be9fe571000988b713ac) Update SevenZipFactory to consistently call OpenAsyncArchive methods - [`2180df3`](https://github.com/adamhathcock/sharpcompress/commit/2180df331899415a52b5dce9299dbd0445b1087c) Pass CancellationToken.None explicitly to OpenAsyncArchive methods - [`cfe59fc`](https://github.com/adamhathcock/sharpcompress/commit/cfe59fc515d2e6bc7fe6ca0972e81e6ed569604d) Merge branch 'adam/async-creation' into copilot/sub-pr-1132 ### 📊 Changes **1 file changed** (+4 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Factories/SevenZipFactory.cs` (+4 -8) </details> ### 📄 Description - [x] Understand the current async architecture in SevenZipArchive - [x] Identify the issue with OpenAsyncArchive methods in SevenZipFactory - [x] Update SevenZipFactory.OpenAsyncArchive methods to call SevenZipArchive.OpenAsyncArchive instead of casting sync OpenArchive - [x] Ensure cancellation tokens are passed through where available - [x] Test the changes - [x] Run code review and address feedback - [ ] Run security scan <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:21:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1579
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?