mirror of
https://github.com/adamhathcock/sharpcompress.git
synced 2026-02-03 21:23:38 +00:00
NUGET package is wrong #2
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sawilde on GitHub (Aug 13, 2013).
Not sure what happened with the packaging but the same assembly has been packaged into all three locations in the
0.10.1.1nuget package.Looking in ILSpy I see that the portable one is
whereas it should be something like
@sawilde commented on GitHub (Aug 14, 2013):
Okay I think I know what has happened - when you build all the projects are building in parallel and this is polluting the binaries in the obj/ folders - by unhooking the parallel build by setting project dependencies seems to resolve the build issue on my local machine
@adamhathcock commented on GitHub (Aug 14, 2013):
You're 100% right.
I have to revert the build locations but the nuspec file will have each assembly named SharpCompress.dll which should cover your original problem.
@sawilde commented on GitHub (Aug 14, 2013):
The name doesn't help - I tried that first off that is why I had to alter the project settings to alter the assembly name
@adamhathcock commented on GitHub (Aug 14, 2013):
I guess I don't understand how if the file names are the same in the package how the references can get confused when the hint paths are pointing to the correct location.
@sawilde commented on GitHub (Aug 14, 2013):
I know it confused me as well as that was the first thing I tried i.e. just the nuspec changes - I think it is all to do with the data that makes up the assembly metadata - is it possible to change the obj/ folder for the 3 'sharpcompress' projects.
Alternatively just change the project dependancies such that you build a sharpcompress library.
I can have a look at fixing it if you want - I'd really like to reference your library in our nuget package rather than my nobbled clone.
@adamhathcock commented on GitHub (Aug 14, 2013):
Turns out we can change the obj folder. I'll do that along with your paths and that should fix the issue: http://stackoverflow.com/questions/4735534/how-can-i-redirect-the-bin-and-obj-directories-to-a-different-location
@adamhathcock commented on GitHub (Aug 14, 2013):
https://www.nuget.org/packages/sharpcompress/0.10.1.3
Okay, hopefully this is the last try :)
@sawilde commented on GitHub (Aug 14, 2013):
I'll check by opening up the nuspec package (zip file in disguise) and look at the assemblies. You could also consider adding some helper build scripts + tests to double check your package before you push to nuget. I do similar on the OpenCover repo.
From: Adam Hathcockmailto:notifications@github.com
Sent: 15/08/2013 1:29 AM
To: adamhathcock/sharpcompressmailto:sharpcompress@noreply.github.com
Cc: Shaun Wildemailto:shaun_wilde@hotmail.com
Subject: Re: [sharpcompress] NUGET package is wrong (#5)
https://www.nuget.org/packages/sharpcompress/0.10.1.3
Okay, hopefully this is the last try :)
Reply to this email directly or view it on GitHub:
https://github.com/adamhathcock/sharpcompress/issues/5#issuecomment-22643653
@sawilde commented on GitHub (Aug 15, 2013):
Looks good :) thanks