mirror of
https://github.com/adamhathcock/sharpcompress.git
synced 2026-02-09 05:24:55 +00:00
Add Entry.GetKeyBytes() method #215
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xupefei on GitHub (Jul 15, 2017).
Related to #163, #261 and #266.
Since the string encoding in Zip archive is such a great pain, is it possible to provide a
byte[]which contains raw bytes of file name without decoding, so the user can employ other libs (e.g. Chardet) to process it later?If you think it's okay, I am happy to do it and then open a PR :-)
@adamhathcock commented on GitHub (Jul 15, 2017):
Yeah, you should be able to do that. It’s just raw bytes before I try to do something.
A PR with Chardet sounds cool
@adamhathcock commented on GitHub (Jul 15, 2017):
Using some custom decoder function on ArchiveEncoding with the changes in this PR would be good: https://github.com/adamhathcock/sharpcompress/pull/274
@adamhathcock commented on GitHub (Jul 17, 2017):
Solved with 0.18
@xupefei commented on GitHub (Jul 19, 2017):
Just to mention, there is a better and newer library for detect encoding: https://github.com/CharsetDetector/UTF-unknown :P
@adamhathcock commented on GitHub (Jul 19, 2017):
Hah. I had already started but this seems better and exactly the same as I'd do.