starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Writing zero length files to a ZIP causes a crash #23

New Issue
Open
opened 2026-01-29 22:03:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:03:39 +00:00
Owner
Copy Link

Originally created by @ptallett on GitHub (Dec 26, 2014).

Trying to add a zero length file to a ZIP file causes the library to crash. A crude fix is as follows:

In CBZip2OutputStream.cs

    private void MainSort()
    {
        int i, j, ss, sb;
        int[] runningOrder = new int[256];
        int[] copy = new int[256];
        bool[] bigDone = new bool[256];
        int c1, c2;
        int numQSorted;

        /*
        In the various block-sized structures, live data runs
        from 0 to last+NUM_OVERSHOOT_BYTES inclusive.  First,
        set up the overshoot area for block.
        */

        last = last == -1 ? 0 : last;       // PRT: Prevent crash on zero length files

Cheers,
Paul

Originally created by @ptallett on GitHub (Dec 26, 2014). Trying to add a zero length file to a ZIP file causes the library to crash. A crude fix is as follows: In CBZip2OutputStream.cs ``` private void MainSort() { int i, j, ss, sb; int[] runningOrder = new int[256]; int[] copy = new int[256]; bool[] bigDone = new bool[256]; int c1, c2; int numQSorted; /* In the various block-sized structures, live data runs from 0 to last+NUM_OVERSHOOT_BYTES inclusive. First, set up the overshoot area for block. */ last = last == -1 ? 0 : last; // PRT: Prevent crash on zero length files ``` Cheers, Paul
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#23
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?