starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Double Dispose() of ZipWritingStream #237

New Issue
Closed
opened 2026-01-29 22:08:51 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:08:51 +00:00
Owner
Copy Link

Originally created by @aienabled on GitHub (Sep 8, 2017).

Hello!

I've noticed that ZipWritingStream on Dispose method call will produce a new ZipEntry.
But it doesn't have protection against subsequent Dispose call. For example:

using (var stream = zipWriter.WriteToStream(FileNameHeader, new ZipWriterEntryOptions()))
using (var streamWriter = new StreamWriter(stream))
{
   ...
}

it will call dispose for ZipWritingStream two times and produce two zip entries in the archive.
I didn't checked it for other streams (non-zip) but they also could be affected by this issue.

Regards!

Originally created by @aienabled on GitHub (Sep 8, 2017). Hello! I've noticed that ZipWritingStream on `Dispose` method call will produce a new ZipEntry. But it doesn't have protection against subsequent `Dispose` call. For example: ```C# using (var stream = zipWriter.WriteToStream(FileNameHeader, new ZipWriterEntryOptions())) using (var streamWriter = new StreamWriter(stream)) { ... } ``` it will call dispose for ZipWritingStream two times and produce two zip entries in the archive. I didn't checked it for other streams (non-zip) but they also could be affected by this issue. Regards!
claunia added the bugup for grabs labels 2026-01-29 22:08:51 +00:00
claunia commented 2026-01-29 22:08:52 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Sep 8, 2017):

Good find. Any chance for a pull request? :)

@adamhathcock commented on GitHub (Sep 8, 2017): Good find. Any chance for a pull request? :)
claunia commented 2026-01-29 22:08:52 +00:00
Author
Owner
Copy Link

@aienabled commented on GitHub (Sep 8, 2017):

Sure https://github.com/adamhathcock/sharpcompress/pull/295

@aienabled commented on GitHub (Sep 8, 2017): Sure https://github.com/adamhathcock/sharpcompress/pull/295
claunia commented 2026-01-29 22:08:52 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Sep 8, 2017):

Thanks!

@adamhathcock commented on GitHub (Sep 8, 2017): Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug up for grabs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#237
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?