starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Q: ArchiveType vs CompressionType #251

New Issue
Closed
opened 2026-01-29 22:09:00 +00:00 by claunia · 7 comments
claunia commented 2026-01-29 22:09:00 +00:00
Owner
Copy Link

Originally created by @evil-shrike on GitHub (Oct 26, 2017).

Hi!

I can't understand how to choose a format. When I create a stream I use ArchiveFactory.Create(ArchiveType.Zip) but then I have to choose CompressionType :

_zipStream = ArchiveFactory.Create(ArchiveType.Zip);
_zipStream.SaveTo(PackageStream, new WriterOptions(CompressionType.GZip));

why? How do ArchiveType and CompressionType relate to each other?

Moreover this code throws SharpCompress.Common.InvalidFormatException: Invalid compression method: GZip.
Zip archive can't have GZip compression type?
I found out that ArchiveType.Zip is compatible with CompressionType.Deflate. But it's weird API.

Originally created by @evil-shrike on GitHub (Oct 26, 2017). Hi! I can't understand how to choose a format. When I create a stream I use `ArchiveFactory.Create(ArchiveType.Zip)` but then I have to choose CompressionType : ``` _zipStream = ArchiveFactory.Create(ArchiveType.Zip); _zipStream.SaveTo(PackageStream, new WriterOptions(CompressionType.GZip)); ``` why? How do ArchiveType and CompressionType relate to each other? Moreover this code throws SharpCompress.Common.InvalidFormatException: Invalid compression method: GZip. Zip archive can't have GZip compression type? I found out that ArchiveType.Zip is compatible with CompressionType.Deflate. But it's weird API.
claunia added the question label 2026-01-29 22:09:00 +00:00
claunia commented 2026-01-29 22:09:01 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Oct 26, 2017):

You've got it it seems. Yes, GZip is slightly weird and isn't supported on Zip as detailed here: https://github.com/adamhathcock/sharpcompress/wiki/Supported-Formats

Yes, it is slightly weird because it's trying to be powerful. If you've got suggestions on how to fix the API, then please let me know.

@adamhathcock commented on GitHub (Oct 26, 2017): You've got it it seems. Yes, GZip is slightly weird and isn't supported on Zip as detailed here: https://github.com/adamhathcock/sharpcompress/wiki/Supported-Formats Yes, it is slightly weird because it's trying to be powerful. If you've got suggestions on how to fix the API, then please let me know.
claunia commented 2026-01-29 22:09:01 +00:00
Author
Owner
Copy Link

@evil-shrike commented on GitHub (Oct 26, 2017):

Ok, got it.
ArchiveType determines a subset of compression types.
Well, I'd suggest some default SaveTo:

interface IWritableArchive {
  void SaveTo(Stream stream, WriterOptions options = null);
}

if no WriterOptions was specified then the lib will choose some default based on its ArchiveType.

@evil-shrike commented on GitHub (Oct 26, 2017): Ok, got it. ArchiveType determines a subset of compression types. Well, I'd suggest some default `SaveTo`: ``` interface IWritableArchive { void SaveTo(Stream stream, WriterOptions options = null); } ``` if no `WriterOptions` was specified then the lib will choose some default based on its ArchiveType.
claunia commented 2026-01-29 22:09:02 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Oct 26, 2017):

You can also just put CompressionType in directly as it's implicitly converted.

@adamhathcock commented on GitHub (Oct 26, 2017): You can also just put `CompressionType` in directly as it's implicitly converted.
claunia commented 2026-01-29 22:09:02 +00:00
Author
Owner
Copy Link

@evil-shrike commented on GitHub (Oct 26, 2017):

Ok, that's nice.
But I meant to allow skipping CompressionType at all: zipArchive.SaveTo(stream)

@evil-shrike commented on GitHub (Oct 26, 2017): Ok, that's nice. But I meant to allow skipping `CompressionType` at all: `zipArchive.SaveTo(stream)`
claunia commented 2026-01-29 22:09:03 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Oct 26, 2017):

Yeah that's fine too.

@adamhathcock commented on GitHub (Oct 26, 2017): Yeah that's fine too.
claunia commented 2026-01-29 22:09:03 +00:00
Author
Owner
Copy Link

@evil-shrike commented on GitHub (Oct 26, 2017):

but it doesn't work ) there's no such method in IWritableArchive

@evil-shrike commented on GitHub (Oct 26, 2017): but it doesn't work ) there's no such method in `IWritableArchive`
claunia commented 2026-01-29 22:09:04 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Oct 26, 2017):

Looks like this https://github.com/adamhathcock/sharpcompress/blob/master/tests/SharpCompress.Test/Zip/ZipArchiveTests.cs#L269

@adamhathcock commented on GitHub (Oct 26, 2017): Looks like this https://github.com/adamhathcock/sharpcompress/blob/master/tests/SharpCompress.Test/Zip/ZipArchiveTests.cs#L269
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label question
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#251
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?