starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-04-05 21:51:09 +00:00
Code Issues 975 Packages Projects Releases 25 Wiki Activity

Please do not absorb System.Buffers. Thanks #267

New Issue
Closed
opened 2026-01-29 22:09:16 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:09:16 +00:00
Owner
Copy Link

Originally created by @yinyue200 on GitHub (Dec 16, 2017).

Just use a lower version (4.0) can make ArrayPool running on Mono. Absorbing System.Buffers broke some app that already referenced System.Buffers. because your make a public abstract class ArrayPool<T>
Absorbing System.Buffers make the library can't use the shared object of ArrayPool, it reduce the benefits.
Thanks.

Originally created by @yinyue200 on GitHub (Dec 16, 2017). Just use a lower version (4.0) can make ArrayPool running on Mono. Absorbing System.Buffers broke some app that already referenced System.Buffers. because your make a `public abstract class ArrayPool<T>` Absorbing System.Buffers make the library can't use the shared object of ArrayPool, it reduce the benefits. Thanks.
claunia commented 2026-01-29 22:09:17 +00:00
Author
Owner
Copy Link

@yinyue200 commented on GitHub (Dec 16, 2017):

Sample repo

tim 20171216093502

@yinyue200 commented on GitHub (Dec 16, 2017): [Sample repo](https://github.com/yinyue200/sysbuffers_monotest) ![tim 20171216093502](https://user-images.githubusercontent.com/13848771/34066069-761d05ac-e244-11e7-81f7-88235c6e8662.png)
claunia commented 2026-01-29 22:09:17 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Dec 16, 2017):

Yeah I should have changed the visibility and probably even namespace. Will fix and release

@adamhathcock commented on GitHub (Dec 16, 2017): Yeah I should have changed the visibility and probably even namespace. Will fix and release
claunia commented 2026-01-29 22:09:17 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Dec 16, 2017):

https://www.nuget.org/packages/sharpcompress/0.19.2

@adamhathcock commented on GitHub (Dec 16, 2017): https://www.nuget.org/packages/sharpcompress/0.19.2
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#267
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?