Chinese Garbled #269

@adamhathcock commented on GitHub (Jan 8, 2018):

yeah it is...set it to a different code page

@adamhathcock commented on GitHub (Jan 8, 2018): yeah it is...set it to a different code page

claunia commented

@JohnnyWoong commented on GitHub (Jan 8, 2018):

what do u mean?set to encode.default?

@JohnnyWoong commented on GitHub (Jan 8, 2018): what do u mean?set to encode.default?

claunia commented

@adamhathcock commented on GitHub (Jan 8, 2018):

https://github.com/adamhathcock/sharpcompress/issues/149 is similar

there still might need to be code changes to totally fix things

@adamhathcock commented on GitHub (Jan 8, 2018): https://github.com/adamhathcock/sharpcompress/issues/149 is similar there still might need to be code changes to totally fix things

claunia commented

@JohnnyWoong commented on GitHub (Jan 8, 2018):

ok,i will try that first,thx

@JohnnyWoong commented on GitHub (Jan 8, 2018): ok,i will try that first,thx

claunia commented

@JohnnyWoong commented on GitHub (Jan 8, 2018):

y i can delete zip file after i uncompress it,but cant delete 7z file after i uncompress it?

@JohnnyWoong commented on GitHub (Jan 8, 2018): y i can delete zip file after i uncompress it,but cant delete 7z file after i uncompress it?

claunia commented

@adamhathcock commented on GitHub (Jan 8, 2018):

make sure everything is disposed. You'll need to show me a code sample of what you're doing if you think you've disposed everything

@adamhathcock commented on GitHub (Jan 8, 2018): make sure everything is disposed. You'll need to show me a code sample of what you're doing if you think you've disposed everything

claunia commented

@JohnnyWoong commented on GitHub (Jan 8, 2018):

//zip uncompress and delete
using (var archive = ZipArchive.Open(file))
            {
                foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory))
                {
                    entry.WriteToDirectory(folder, new ExtractionOptions()
                    {
                        ExtractFullPath = true,
                        Overwrite = true
                    });
                }
            }
File.Delete(file);
//7zip uncompress and delete
using (var archive = RarArchive.Open(file))
            {
                foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory))
                {
                    entry.WriteToDirectory(folder, new ExtractionOptions()
                    {
                        ExtractFullPath = true,
                        Overwrite = true
                    });
                }
            }
File.Delete(file);

@JohnnyWoong commented on GitHub (Jan 8, 2018): ```c# //zip uncompress and delete using (var archive = ZipArchive.Open(file)) { foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory)) { entry.WriteToDirectory(folder, new ExtractionOptions() { ExtractFullPath = true, Overwrite = true }); } } File.Delete(file); //7zip uncompress and delete using (var archive = RarArchive.Open(file)) { foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory)) { entry.WriteToDirectory(folder, new ExtractionOptions() { ExtractFullPath = true, Overwrite = true }); } } File.Delete(file); ```

claunia commented

@adamhathcock commented on GitHub (Jan 8, 2018):

I'll take a look later but RarArchive isn't 7Zip

@adamhathcock commented on GitHub (Jan 8, 2018): I'll take a look later but `RarArchive` isn't 7Zip

claunia commented

@JohnnyWoong commented on GitHub (Jan 8, 2018):

sry,my copy wrong,RarArchive should be SevenZipArchive,the 7z file cant delete,i haven't test rar file

@JohnnyWoong commented on GitHub (Jan 8, 2018): sry,my copy wrong,RarArchive should be SevenZipArchive,the 7z file cant delete,i haven't test rar file

claunia commented

@adamhathcock commented on GitHub (Jan 8, 2018):

well, I need the exact code, not a copy/guess. As far as I can tell, disposal works correctly.

@adamhathcock commented on GitHub (Jan 8, 2018): well, I need the exact code, not a copy/guess. As far as I can tell, disposal works correctly.

claunia commented

@JohnnyWoong commented on GitHub (Jan 8, 2018):

using (var archive = SevenZipArchive.Open(file))
            {
                foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory))
                {
                    entry.WriteToDirectory(folder, new ExtractionOptions()
                    {
                        ExtractFullPath = true,
                        Overwrite = true
                    });
                }
            }
File.Delete(file);

thats is the code,cause i write 7z,zip and rar,so i copy the wrong one..

@JohnnyWoong commented on GitHub (Jan 8, 2018): ```c# using (var archive = SevenZipArchive.Open(file)) { foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory)) { entry.WriteToDirectory(folder, new ExtractionOptions() { ExtractFullPath = true, Overwrite = true }); } } File.Delete(file); ``` thats is the code,cause i write 7z,zip and rar,so i copy the wrong one..

claunia commented

@adamhathcock commented on GitHub (Jan 8, 2018):

I literally tested that and it works for me. Next step for debugging would be for you to provide a github repo sample with the bug that I could validate didn't work.

@adamhathcock commented on GitHub (Jan 8, 2018): I literally tested that and it works for me. Next step for debugging would be for you to provide a github repo sample with the bug that I could validate didn't work.

claunia commented

@JohnnyWoong commented on GitHub (Jan 9, 2018):

I dont knw y,but same code is work 4 me today...sry abt that
By the way,7z uncompress is too slow,250MB zip uncompress only need less 1 min,y 275MB 7z uncompress need about 30M..

@JohnnyWoong commented on GitHub (Jan 9, 2018): I dont knw y,but same code is work 4 me today...sry abt that By the way,7z uncompress is too slow,250MB zip uncompress only need less 1 min,y 275MB 7z uncompress need about 30M..

claunia commented