starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-06 13:34:58 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

leaveOpen argument for XZStream constructor #291

New Issue
Closed
opened 2026-01-29 22:09:36 +00:00 by claunia · 4 comments
claunia commented 2026-01-29 22:09:36 +00:00
Owner
Copy Link

Originally created by @ied206 on GitHub (Apr 21, 2018).

While SharpCompress.Compressors classes like DeflateStream and BZip2Stream have leaveOpen argument in its constructor, XZStream and RarStream does not.

Is there any special reason for this? It would be better to have leaveOpen to every Stream in SharpCompress.Compressors, to match convention of System.IO.Compression.

Originally created by @ied206 on GitHub (Apr 21, 2018). While `SharpCompress.Compressors` classes like `DeflateStream` and `BZip2Stream` have `leaveOpen` argument in its constructor, `XZStream` and `RarStream` does not. Is there any special reason for this? It would be better to have `leaveOpen` to every Stream in `SharpCompress.Compressors`, to match convention of `System.IO.Compression`.
claunia commented 2026-01-29 22:09:37 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Apr 21, 2018):

No special reason other than just didn’t think about it.

Rather than implementing leaveOpen on each, I should remove it and use NonDisposingStream to wrap instead.

@adamhathcock commented on GitHub (Apr 21, 2018): No special reason other than just didn’t think about it. Rather than implementing `leaveOpen` on each, I should remove it and use `NonDisposingStream` to wrap instead.
claunia commented 2026-01-29 22:09:37 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Apr 22, 2018):

Fixing here: https://github.com/adamhathcock/sharpcompress/pull/369

@adamhathcock commented on GitHub (Apr 22, 2018): Fixing here: https://github.com/adamhathcock/sharpcompress/pull/369
claunia commented 2026-01-29 22:09:38 +00:00
Author
Owner
Copy Link

@ied206 commented on GitHub (May 5, 2018):

Thanks for fixing!

@ied206 commented on GitHub (May 5, 2018): Thanks for fixing!
claunia commented 2026-01-29 22:09:38 +00:00
Author
Owner
Copy Link

@amoraitis commented on GitHub (Jan 20, 2020):

Hi @adamhathcock, I am upgrading SharpCompress from 0.10.3 to the latest and I noticed that your removed leaveOpen parameter from BZip2Stream's and GZipStreams constructors. Should I add something to my implementation other than removing the leaveOpen parameter from the constructors?

@amoraitis commented on GitHub (Jan 20, 2020): Hi @adamhathcock, I am upgrading `SharpCompress` from `0.10.3` to the latest and I noticed that your removed `leaveOpen` parameter from `BZip2Stream`'s and `GZipStream`s constructors. Should I add something to my implementation other than removing the `leaveOpen` parameter from the constructors?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?