starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-11 05:24:56 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

KeyParameter should be private or should use other namespace #295

New Issue
Open
opened 2026-01-29 22:09:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:09:39 +00:00
Owner
Copy Link

Originally created by @Inumedia on GitHub (May 6, 2018).

Hi,

Love the library, it's saved me a lot of hassle with deflate calls. However, https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Crypto/KeyParameter.cs definitely needs to either have a different namespace or be private as it interferes with including actual BouncyCastle crypto libraries.

image

Originally created by @Inumedia on GitHub (May 6, 2018). Hi, Love the library, it's saved me a lot of hassle with deflate calls. However, https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Crypto/KeyParameter.cs definitely needs to either have a different namespace or be private as it interferes with including actual BouncyCastle crypto libraries. ![image](https://user-images.githubusercontent.com/856822/39671285-f4544d38-50e2-11e8-8324-166a217185c3.png)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?