KeyParameter should be private or should use other namespace #298

Closed
opened 2026-01-29 22:09:42 +00:00 by claunia · 4 comments
Owner

Originally created by @Inumedia on GitHub (May 6, 2018).

Hi,

Love the library, it's saved me a lot of hassle with deflate calls. However, https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Crypto/KeyParameter.cs definitely needs to either have a different namespace or be private as it interferes with including actual BouncyCastle crypto libraries.

image

Originally created by @Inumedia on GitHub (May 6, 2018). Hi, Love the library, it's saved me a lot of hassle with deflate calls. However, https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Crypto/KeyParameter.cs definitely needs to either have a different namespace or be private as it interferes with including actual BouncyCastle crypto libraries. ![image](https://user-images.githubusercontent.com/856822/39671285-f4544d38-50e2-11e8-8324-166a217185c3.png)
Author
Owner

@adamhathcock commented on GitHub (May 6, 2018):

Fixed in next release. Thanks!

@adamhathcock commented on GitHub (May 6, 2018): Fixed in next release. Thanks!
Author
Owner

@Inumedia commented on GitHub (May 6, 2018):

That was fast. Is there an ETA for next release? Guessing I should just reference by source for now.

@Inumedia commented on GitHub (May 6, 2018): That was fast. Is there an ETA for next release? Guessing I should just reference by source for now.
Author
Owner

@adamhathcock commented on GitHub (May 6, 2018):

I'll probably do it some time today as I've got a few things ready

@adamhathcock commented on GitHub (May 6, 2018): I'll probably do it some time today as I've got a few things ready
Author
Owner

@Inumedia commented on GitHub (May 6, 2018):

Awesome, thanks!

@Inumedia commented on GitHub (May 6, 2018): Awesome, thanks!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#298