starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-10 13:39:12 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Tar filename with exactly 100 characters gets cut #322

New Issue
Closed
opened 2026-01-29 22:10:07 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 22:10:07 +00:00
Owner
Copy Link

Originally created by @majoreffort on GitHub (Jul 23, 2018).

Filenames with exactly 100 characters loose their last character while writing the header (TarHeader#Write).

I wrote a simple test to verify this issue: See ec044e6f42

I also digged into the code and found the method WriteStringBytes actually writes a maximum of length-1 bytes:

for (i = 0; i < length - 1 && i < name.Length; ++i)
{
    buffer[offset + i] = (byte)name[i];
}

Is this intended and/or tar only supports 99 character entries?
If I replace length - 1 with only length the tar tests work fine.

Originally created by @majoreffort on GitHub (Jul 23, 2018). Filenames with exactly 100 characters loose their last character while writing the header (TarHeader#Write). I wrote a simple test to verify this issue: See ec044e6f42a60159e36b95689960ba55e4fbcb4f I also digged into the code and found the method `WriteStringBytes` actually writes a maximum of length-1 bytes: ```csharp for (i = 0; i < length - 1 && i < name.Length; ++i) { buffer[offset + i] = (byte)name[i]; } ``` Is this intended and/or tar only supports 99 character entries? If I replace `length - 1` with only `length` the tar tests work fine.
claunia commented 2026-01-29 22:10:08 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jul 23, 2018):

Mind submitting the test and a fix as a pull request? Thanks!

@adamhathcock commented on GitHub (Jul 23, 2018): Mind submitting the test and a fix as a pull request? Thanks!
claunia commented 2026-01-29 22:10:08 +00:00
Author
Owner
Copy Link

@majoreffort commented on GitHub (Jul 23, 2018):

Sure, added PR #408.

@majoreffort commented on GitHub (Jul 23, 2018): Sure, added PR #408.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#322
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?