starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-08 13:34:57 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Change IArchive.Entries from IEnumerable<IArchiveEntry> to ICollection<IArchiveEntry> #341

New Issue
Open
opened 2026-01-29 22:10:25 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:10:25 +00:00
Owner
Copy Link

Originally created by @AlexeiScherbakov on GitHub (Jan 2, 2019).

When using IArchive interface, I cannot get total count of entries. But all implementations are actually ICollection (AbstractArchive<TEntry, TVolume>.Entries is a Collection)

Originally created by @AlexeiScherbakov on GitHub (Jan 2, 2019). When using IArchive interface, I cannot get total count of entries. But all implementations are actually ICollection (AbstractArchive<TEntry, TVolume>.Entries is a Collection)
claunia commented 2026-01-29 22:10:26 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jan 2, 2019):

Created pull request. Will finish next week.

@adamhathcock commented on GitHub (Jan 2, 2019): Created pull request. Will finish next week.
claunia commented 2026-01-29 22:10:26 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jan 3, 2019):

Not sure I can do this because I'm still supporting .NET 3.5. The reason is because of generic covariance which didn't exist until .NET 4.0.

@adamhathcock commented on GitHub (Jan 3, 2019): Not sure I can do this because I'm still supporting .NET 3.5. The reason is because of generic covariance which didn't exist until .NET 4.0.
claunia commented 2026-01-29 22:10:26 +00:00
Author
Owner
Copy Link

@AlexeiScherbakov commented on GitHub (Jan 3, 2019):

I see. May be better introduce property int EntriesCount{get;} in IArchive.
And property bool EntriesCountAvaliable{get;} - if situation when we cannot
get count is exist

чт, 3 Янв 2019, 17:34 Adam Hathcock notifications@github.com:

Not sure I can do this because I'm still supporting .NET 3.5. The reason
is because of generic covariance which didn't exist until .NET 4.0.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/adamhathcock/sharpcompress/issues/432#issuecomment-451160216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIQ7O18YrR76fdXsbDQ7ayuVAFHnxLtrks5u_hTegaJpZM4ZmLKo
.

@AlexeiScherbakov commented on GitHub (Jan 3, 2019): I see. May be better introduce property int EntriesCount{get;} in IArchive. And property bool EntriesCountAvaliable{get;} - if situation when we cannot get count is exist чт, 3 Янв 2019, 17:34 Adam Hathcock notifications@github.com: > Not sure I can do this because I'm still supporting .NET 3.5. The reason > is because of generic covariance which didn't exist until .NET 4.0. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/adamhathcock/sharpcompress/issues/432#issuecomment-451160216>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AIQ7O18YrR76fdXsbDQ7ayuVAFHnxLtrks5u_hTegaJpZM4ZmLKo> > . >
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#341
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?