starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

AddAllFromDirectory does not ignore files locked by other process #388

New Issue
Closed
opened 2026-01-29 22:11:06 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 22:11:06 +00:00
Owner
Copy Link

Originally created by @CaledoniaProject on GitHub (Jan 21, 2020).

I'm using the following code to compress a directory:

        using (var archive = ZipArchive.Create())
        {
            archive.AddAllFromDirectory(dirname);
            archive.SaveTo(zipname, options);
        }

When one of the files is not readable, it throws exception.

How can I let it continue and ignore files that can't be read?

Originally created by @CaledoniaProject on GitHub (Jan 21, 2020). I'm using the following code to compress a directory: using (var archive = ZipArchive.Create()) { archive.AddAllFromDirectory(dirname); archive.SaveTo(zipname, options); } When one of the files is not readable, it throws exception. How can I let it continue and ignore files that can't be read?
claunia commented 2026-01-29 22:11:07 +00:00
Author
Owner
Copy Link

@turbolocust commented on GitHub (Jan 21, 2020):

Use the AddEntry method instead.
Take a look at the actual implementation:

public static void AddAllFromDirectory(
	this IWritableArchive writableArchive,
	string filePath, string searchPattern = "*.*", SearchOption searchOption = SearchOption.AllDirectories)
{
	foreach (var path in Directory.EnumerateFiles(filePath, searchPattern, searchOption))
	{
		var fileInfo = new FileInfo(path);
		writableArchive.AddEntry(path.Substring(filePath.Length), fileInfo.OpenRead(), true, fileInfo.Length,
								 fileInfo.LastWriteTime);
	}
}
@turbolocust commented on GitHub (Jan 21, 2020): Use the **AddEntry** method instead. Take a look at the actual implementation: ```csharp public static void AddAllFromDirectory( this IWritableArchive writableArchive, string filePath, string searchPattern = "*.*", SearchOption searchOption = SearchOption.AllDirectories) { foreach (var path in Directory.EnumerateFiles(filePath, searchPattern, searchOption)) { var fileInfo = new FileInfo(path); writableArchive.AddEntry(path.Substring(filePath.Length), fileInfo.OpenRead(), true, fileInfo.Length, fileInfo.LastWriteTime); } } ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?