starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-09 05:24:55 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Use GitHub actions for Build and Deploying to NuGet #394

New Issue
Open
opened 2026-01-29 22:11:13 +00:00 by claunia · 7 comments
claunia commented 2026-01-29 22:11:13 +00:00
Owner
Copy Link

Originally created by @adamhathcock on GitHub (Apr 3, 2020).

Need to modernize more as I'm doing professionally.

Originally created by @adamhathcock on GitHub (Apr 3, 2020). Need to modernize more as I'm doing professionally.
claunia added the enhancementup for grabs labels 2026-01-29 22:11:13 +00:00
claunia commented 2026-01-29 22:11:14 +00:00
Author
Owner
Copy Link

@digitalcoyote commented on GitHub (Oct 3, 2020):

I'd be willing to try and throw this together if I can get some information on it:

  • Is there a difference in the OS builds? or should only a single nuget package be published.
  • Do you want every package published as a pre-release or just on releases?
  • You will need to setup the gitHub secrets to get it to actually work (don't want credentials in the source control 🤯 )
@digitalcoyote commented on GitHub (Oct 3, 2020): I'd be willing to try and throw this together if I can get some information on it: - Is there a difference in the OS builds? or should only a single nuget package be published. - Do you want every package published as a pre-release or just on releases? - You will need to setup the gitHub secrets to get it to actually work (don't want credentials in the source control :exploding_head: )
claunia commented 2026-01-29 22:11:14 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Oct 3, 2020):

Have to build on windows for full framework target for now.

I guess this would be the time to have a release branch for actual nuget push activation.

I'll set up secrets if I know what to do 😬

@adamhathcock commented on GitHub (Oct 3, 2020): Have to build on windows for full framework target for now. I guess this would be the time to have a release branch for actual nuget push activation. I'll set up secrets if I know what to do 😬
claunia commented 2026-01-29 22:11:14 +00:00
Author
Owner
Copy Link

@digitalcoyote commented on GitHub (Oct 16, 2020):

I finally got around to starting on this.

  • Do you intend to version releases manually?
    • or would you like to use something like GitVersion?
  • Also, with the GitHub CLI, it could create the actual GitHub release as part of the action

I'm currently working under the assumption of using gitversion and passing the version as an argument to the build script (so it can be ignored and allow the project to be built if gitversion is not installed). I hope to have it running without the actual nuget publish later tonight.

@digitalcoyote commented on GitHub (Oct 16, 2020): I finally got around to starting on this. - Do you intend to version releases manually? - or would you like to use something like [GitVersion](https://github.com/GitTools/GitVersion)? - Also, with the GitHub CLI, it could create the actual GitHub release as part of the action I'm currently working under the assumption of using gitversion and passing the version as an argument to the build script (so it can be ignored and allow the project to be built if gitversion is not installed). I hope to have it running without the actual nuget publish later tonight.
claunia commented 2026-01-29 22:11:14 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Oct 19, 2020):

So far I've been doing things manually as changes have been few and very long inbetween. Not sure how I feel about transitioning to GitVersion and auto-magic releasing.

Does doing gh release roll up PRs and/or issues into it? What kind of tagging am I going to have to switch to?

@adamhathcock commented on GitHub (Oct 19, 2020): So far I've been doing things manually as changes have been few and very long inbetween. Not sure how I feel about transitioning to GitVersion and auto-magic releasing. Does doing gh release roll up PRs and/or issues into it? What kind of tagging am I going to have to switch to?
claunia commented 2026-01-29 22:11:15 +00:00
Author
Owner
Copy Link

@digitalcoyote commented on GitHub (Oct 19, 2020):

So far I've been doing things manually as changes have been few and very long inbetween. Not sure how I feel about transitioning to GitVersion and auto-magic releasing.

I set the release up so it would only make Draft Releases (creates the tag for the commit using the version that was generated. I can rip both of those out fairly easily.

Does doing gh release roll up PRs and/or issues into it? What kind of tagging am I going to have to switch to?

I can set the action to specifically ignore PR's and only look at the release branch (for testing I was using master). The tagging is the same that is used if you let GitHub create the tag by specifying a new tag name for a release. I set it up to use the version as the tag (I believe this should match the current convention).

If you wanted these to be there in case you ever decide to switch to it, I can comment it out as well and add a few extra lines to document what each piece is doing. I haven't fully switched to automatic releases yet myself.

@digitalcoyote commented on GitHub (Oct 19, 2020): > So far I've been doing things manually as changes have been few and very long inbetween. Not sure how I feel about transitioning to GitVersion and auto-magic releasing. I set the release up so it would only make Draft Releases (creates the tag for the commit using the version that was generated. I can rip both of those out fairly easily. > Does doing gh release roll up PRs and/or issues into it? What kind of tagging am I going to have to switch to? I can set the action to specifically ignore PR's and only look at the release branch (for testing I was using master). The tagging is the same that is used if you let GitHub create the tag by specifying a new tag name for a release. I set it up to use the version as the tag (I believe this should match the current convention). If you wanted these to be there in case you ever decide to switch to it, I can comment it out as well and add a few extra lines to document what each piece is doing. I haven't fully switched to automatic releases yet myself.
claunia commented 2026-01-29 22:11:15 +00:00
Author
Owner
Copy Link

@digitalcoyote commented on GitHub (Oct 19, 2020):

I'm starting work, but before I forget, I was looking into it, and if you want to use Manual Release, I can set the workflow to trigger on Release in addition to PR/Push, but only publish to NuGet on Release.

Let me know what you feel comfortable with and I'll see what I can do to make it happen.

@digitalcoyote commented on GitHub (Oct 19, 2020): I'm starting work, but before I forget, I was looking into it, and if you want to use Manual Release, I can set the workflow to trigger on Release in addition to PR/Push, but only publish to NuGet on Release. Let me know what you feel comfortable with and I'll see what I can do to make it happen.
claunia commented 2026-01-29 22:11:15 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Oct 20, 2020):

Thanks for this @digitalcoyote, I really appreciate the eagerness to help.

I'm going to have not change the release strategy at this time. Personally, I have very little time to devote to this project and there does not seem any interest in co-maintainers or major contributions to justify me changing anything significant in how this project is managed. I just don't have the headspace to wrap my head around it.

I don't want to discourage you from contributing to this project or any other. I hope you keep contributing!

@adamhathcock commented on GitHub (Oct 20, 2020): Thanks for this @digitalcoyote, I really appreciate the eagerness to help. I'm going to have not change the release strategy at this time. Personally, I have very little time to devote to this project and there does not seem any interest in co-maintainers or major contributions to justify me changing anything significant in how this project is managed. I just don't have the headspace to wrap my head around it. I don't want to discourage you from contributing to this project or any other. I hope you keep contributing!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label enhancement up for grabs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#394
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?