starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Not implemented Stream methods are expected to throw NotSupportedException #409

New Issue
Open
opened 2026-01-29 22:11:30 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 22:11:30 +00:00
Owner
Copy Link

Originally created by @claunia on GitHub (Aug 24, 2020).

Hi,

As in
https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Compressors/LZMA/LZipStream.cs#L108

all other software expects that to throw a NotSupportedException as a normal condition to detect they cannot seek or get the size, however throwing a NotImplementedException makes other libraries (e.g. DotNetZip) not work properly.

E.g.:
fbad143e71/src/Zip.Shared/ZipEntry.Write.cs (L1510)

Originally created by @claunia on GitHub (Aug 24, 2020). Hi, As in https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Compressors/LZMA/LZipStream.cs#L108 all other software expects that to throw a NotSupportedException as a normal condition to detect they cannot seek or get the size, however throwing a NotImplementedException makes other libraries (e.g. DotNetZip) not work properly. E.g.: https://github.com/haf/DotNetZip.Semverd/blob/fbad143e71ab3069b1bd7ae17eabb81543747457/src/Zip.Shared/ZipEntry.Write.cs#L1510
claunia added the bugup for grabs labels 2026-01-29 22:11:30 +00:00
claunia commented 2026-01-29 22:11:30 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Aug 25, 2020):

Happy to change the exception if you don't mind submitting a PR to clean that exception (and possibly other locations)

@adamhathcock commented on GitHub (Aug 25, 2020): Happy to change the exception if you don't mind submitting a PR to clean that exception (and possibly other locations)
claunia commented 2026-01-29 22:11:31 +00:00
Author
Owner
Copy Link

@ds5678 commented on GitHub (Dec 23, 2022):

I think this has been already resolved.

@ds5678 commented on GitHub (Dec 23, 2022): I think this has been already resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug up for grabs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#409
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?