starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

zip format, Chinese password decompression failed #413

New Issue
Open
opened 2026-01-29 22:11:31 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:11:31 +00:00
Owner
Copy Link

Originally created by @toolgood on GitHub (Aug 29, 2020).

zip format, Chinese password decompression failed
Knowing that the password is "公众号身披御光的盟国"
But the decompression failed

Encoding: GB18030
test file: https://github.com/toolgood/OtherFiles/blob/master/SharpCompress/passwordError.zip

        private static bool CheckPassword3(string file, string password, Encoding encoding2, Encoding encoding3)
        {
            ReaderOptions options = new ReaderOptions();
            options.LookForHeader = true;
            options.LeaveStreamOpen = false;
            if (string.IsNullOrWhiteSpace(password) == false) {
                options.Password = password;
            }
            //options.ArchiveEncoding = new ArchiveEncoding(Encoding.GetEncoding("GB18030"), Encoding.GetEncoding("GB18030"));
            options.ArchiveEncoding = new ArchiveEncoding(encoding2, encoding3);

            var archive = ArchiveFactory.Open(file, options);
            try {
                if (archive.IsComplete) {
                    var entry = archive.Entries.Where(entry => !entry.IsDirectory).OrderBy(e => e.CompressedSize).FirstOrDefault();
                    if (entry != null) {
                        using (var ms = new MemoryStream()) {
                            entry.WriteTo(ms);
                        }
                        return true;
                    }
                }
            } catch (Exception e) {
            } finally {
                archive.Dispose();
            }
            return false;
        }
Originally created by @toolgood on GitHub (Aug 29, 2020). zip format, Chinese password decompression failed Knowing that the password is "公众号身披御光的盟国" But the decompression failed Encoding: GB18030 test file: https://github.com/toolgood/OtherFiles/blob/master/SharpCompress/passwordError.zip ``` private static bool CheckPassword3(string file, string password, Encoding encoding2, Encoding encoding3) { ReaderOptions options = new ReaderOptions(); options.LookForHeader = true; options.LeaveStreamOpen = false; if (string.IsNullOrWhiteSpace(password) == false) { options.Password = password; } //options.ArchiveEncoding = new ArchiveEncoding(Encoding.GetEncoding("GB18030"), Encoding.GetEncoding("GB18030")); options.ArchiveEncoding = new ArchiveEncoding(encoding2, encoding3); var archive = ArchiveFactory.Open(file, options); try { if (archive.IsComplete) { var entry = archive.Entries.Where(entry => !entry.IsDirectory).OrderBy(e => e.CompressedSize).FirstOrDefault(); if (entry != null) { using (var ms = new MemoryStream()) { entry.WriteTo(ms); } return true; } } } catch (Exception e) { } finally { archive.Dispose(); } return false; } ```
claunia added the bugup for grabs labels 2026-01-29 22:11:31 +00:00
claunia commented 2026-01-29 22:11:32 +00:00
Author
Owner
Copy Link

@toolgood commented on GitHub (Aug 29, 2020):

Use the 7-Zip Extra command line to decompress correctly

7-Zip Extra can be downloaded at https://www.7-zip.org/download.html

D:\Downloads\7z1900-extra>7za e -oD:\Downloads\20200823\jiaoao\存档.无密码 -p公众号身披御光的盟国 D:\Downloads\20200823\jiaoao\passwordError.zip

7-Zip (a) 19.00 (x86) : Copyright (c) 1999-2018 Igor Pavlov : 2019-02-21

Scanning the drive for archives:
1 file, 188 bytes (1 KiB)

Extracting archive: D:\Downloads\20200823\jiaoao\passwordError.zip
--
Path = D:\Downloads\20200823\jiaoao\passwordError.zip
Type = zip
Physical Size = 188

Everything is Ok

Size:       12
Compressed: 188
@toolgood commented on GitHub (Aug 29, 2020): Use the 7-Zip Extra command line to decompress correctly 7-Zip Extra can be downloaded at https://www.7-zip.org/download.html ``` D:\Downloads\7z1900-extra>7za e -oD:\Downloads\20200823\jiaoao\存档.无密码 -p公众号身披御光的盟国 D:\Downloads\20200823\jiaoao\passwordError.zip 7-Zip (a) 19.00 (x86) : Copyright (c) 1999-2018 Igor Pavlov : 2019-02-21 Scanning the drive for archives: 1 file, 188 bytes (1 KiB) Extracting archive: D:\Downloads\20200823\jiaoao\passwordError.zip -- Path = D:\Downloads\20200823\jiaoao\passwordError.zip Type = zip Physical Size = 188 Everything is Ok Size: 12 Compressed: 188 ```
claunia commented 2026-01-29 22:11:32 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Aug 29, 2020):

Thanks for the repro steps. I'll look at this soon.

Not sure why encoding has been difficult for me in this project. I assume UTF8 doesn't work?

@adamhathcock commented on GitHub (Aug 29, 2020): Thanks for the repro steps. I'll look at this soon. Not sure why encoding has been difficult for me in this project. I assume UTF8 doesn't work?
claunia commented 2026-01-29 22:11:32 +00:00
Author
Owner
Copy Link

@CasualPokePlayer commented on GitHub (May 10, 2023):

Use the 7-Zip Extra command line to decompress correctly

This doesn't actually work correctly unless you're on a Chinese system anyways (which seems to use GB18030 for Command Prompt, as that's the system page). What gets sent to 7zip is ultimately just a byte array, which on your system is decoded correctly from the string using GB18030. On other systems (like English systems using Windows-1252), it will not work (as those characters are unsupported). That is unless you translate the raw bytes into the user's system page. For Windows-1252, this would be ¹«ÖÚºÅÉíÅûÓù¹âµÄÃ˹ú. As long as the string gets decoded into the correct byte array, it works.

@CasualPokePlayer commented on GitHub (May 10, 2023): > Use the 7-Zip Extra command line to decompress correctly This doesn't actually work correctly unless you're on a Chinese system anyways (which seems to use GB18030 for Command Prompt, as that's the system page). What gets sent to 7zip is ultimately just a byte array, which on your system is decoded correctly from the string using GB18030. On other systems (like English systems using Windows-1252), it will not work (as those characters are unsupported). That is unless you translate the raw bytes into the user's system page. For Windows-1252, this would be `¹«ÖÚºÅÉíÅûÓù¹âµÄÃ˹ú`. As long as the string gets decoded into the correct byte array, it works.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug up for grabs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?