starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Encoding with ArchiveFactory.WriteToDirectory #458

New Issue
Open
opened 2026-01-29 22:12:24 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 22:12:24 +00:00
Owner
Copy Link

Originally created by @TheRisenPhoenix on GitHub (May 4, 2021).

I've ran into an issue where I want to extract a zip archive. Inside the archive, there is a file with german Umlaute: "Übung.txt"
I use ArchiveFactory.WriteToDirectory to extract the archive, but the extracted file shows some questionmark instead of "Ü". (so, apparently, the encoding is wrong). I am using Windows 10.
The method provides an option-argument, however it does not contain anything encoding-related.

I searched the documentation and came across an example usage of reading the file and extracting it. There, you can provide some reader options:

private static void ExtractArchive(string source, string destination) {
    var opts = new ReaderOptions();
    var encoding = Encoding.GetEncoding(1252);
    
    opts.ArchiveEncoding = new ArchiveEncoding {
        CustomDecoder = (data, _, _) => encoding.GetString(data),
    };
    
    using Stream inStream = File.OpenRead(source);
    using Stream outStream = File.OpenWrite(destination);
    using var reader = ReaderFactory.Open(inStream, opts);
    while (reader.MoveToNextEntry())
    {
        if (!reader.Entry.IsDirectory) {
            using var entryStream = reader.OpenEntryStream();
            entryStream.CopyTo(outStream);
        }
    }
 }

I tried various different encodings, but none worked.

Am I doing something incorrectly? Or might this be a bug?
Also, I'm wondering what the reason is that ReaderFactory.Open has an option-argument that provides encoding information, but ArchiveFactory.WriteToDirectory doesn't?

Originally created by @TheRisenPhoenix on GitHub (May 4, 2021). I've ran into an issue where I want to extract a zip archive. Inside the archive, there is a file with german _Umlaute_: "Übung.txt" I use `ArchiveFactory.WriteToDirectory` to extract the archive, but the extracted file shows some questionmark instead of "Ü". (so, apparently, the encoding is wrong). I am using Windows 10. The method provides an option-argument, however it does not contain anything encoding-related. I searched the documentation and came across an example usage of reading the file and extracting it. There, you can provide some reader options: ``` private static void ExtractArchive(string source, string destination) { var opts = new ReaderOptions(); var encoding = Encoding.GetEncoding(1252); opts.ArchiveEncoding = new ArchiveEncoding { CustomDecoder = (data, _, _) => encoding.GetString(data), }; using Stream inStream = File.OpenRead(source); using Stream outStream = File.OpenWrite(destination); using var reader = ReaderFactory.Open(inStream, opts); while (reader.MoveToNextEntry()) { if (!reader.Entry.IsDirectory) { using var entryStream = reader.OpenEntryStream(); entryStream.CopyTo(outStream); } } } ``` I tried various different encodings, but none worked. Am I doing something incorrectly? Or might this be a bug? Also, I'm wondering what the reason is that `ReaderFactory.Open` has an option-argument that provides encoding information, but `ArchiveFactory.WriteToDirectory` doesn't?
claunia commented 2026-01-29 22:12:25 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jun 4, 2021):

There could be several things going wrong here. Encoding within the archive and/or encoding at the code level once it makes a string. I'm not the best with encodings so I'm not sure. I'd need a sample file to see more.

WriteToDirectory is an extension method that's just a helper. It's not meant to cover all scenarios.

@adamhathcock commented on GitHub (Jun 4, 2021): There could be several things going wrong here. Encoding within the archive and/or encoding at the code level once it makes a string. I'm not the best with encodings so I'm not sure. I'd need a sample file to see more. WriteToDirectory is an extension method that's just a helper. It's not meant to cover all scenarios.
claunia commented 2026-01-29 22:12:25 +00:00
Author
Owner
Copy Link

@TheRisenPhoenix commented on GitHub (Jun 4, 2021):

Thanks for your reply!

I prepared a sample file, I hope that it helps you to track down the issue.

Is there anything more I can do to spot the problem?

@TheRisenPhoenix commented on GitHub (Jun 4, 2021): Thanks for your reply! I prepared a [sample file](https://github.com/adamhathcock/sharpcompress/files/6599734/MyZip.zip), I hope that it helps you to track down the issue. Is there anything more I can do to spot the problem?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#458
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?