starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

IEntry.Crc returns a negative number #501

New Issue
Closed
opened 2026-01-29 22:12:57 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 22:12:57 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Feb 26, 2022).

IEntry.Crc Property returns a negative number (eg: -1626075223).

When loading some .gz files, the CRC property will return a negative number. I'm not sure if negative numbers are currently the best solution for sharpcompress. But while converting this CRC to a string, an error occurs.

Test Code:
C# / .net 6.0 / Visual Studio 2022

using SharpCompress.Archives;

var filePath = @"D:\001\001.gz";

using var stream = File.OpenRead(filePath);
var archive = ArchiveFactory.Open(stream);

foreach (var p in archive.Entries)
{
    var data = p.Crc;

    var text = data.ToString("X");
    Console.WriteLine(text);
}

Test Result:

FFFFFFFFD8BF5DCD

String conversion has extra "FFFFFFFF" when CRC is negative number.
There is a detailed explanation about this part on stackoverflow.

https://stackoverflow.com/questions/32940417/unsigned-crc-32-for-python-to-match-javas-crc-32

Do you think it is necessary to normalize all CRCs to positive integers?

Originally created by @ghost on GitHub (Feb 26, 2022). IEntry.Crc Property returns a negative number (eg: -1626075223). When loading some .gz files, the CRC property will return a negative number. I'm not sure if negative numbers are currently the best solution for sharpcompress. But while converting this CRC to a string, an error occurs. Test Code: C# / .net 6.0 / Visual Studio 2022 ``` using SharpCompress.Archives; var filePath = @"D:\001\001.gz"; using var stream = File.OpenRead(filePath); var archive = ArchiveFactory.Open(stream); foreach (var p in archive.Entries) { var data = p.Crc; var text = data.ToString("X"); Console.WriteLine(text); } ``` Test Result: ``` FFFFFFFFD8BF5DCD ``` String conversion has extra "FFFFFFFF" when CRC is **negative number**. There is a detailed explanation about this part on stackoverflow. https://stackoverflow.com/questions/32940417/unsigned-crc-32-for-python-to-match-javas-crc-32 Do you think it is necessary to normalize all CRCs to **positive integers**?
claunia commented 2026-01-29 22:12:58 +00:00
Author
Owner
Copy Link

@Nanook commented on GitHub (Jul 15, 2022):

I've fixed this and will submit a fix.

@Nanook commented on GitHub (Jul 15, 2022): I've fixed this and will submit a fix.
claunia commented 2026-01-29 22:12:58 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 19, 2022):

@Nanook Thank you very much.

@ghost commented on GitHub (Nov 19, 2022): @Nanook Thank you very much.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#501
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?