starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-07 21:22:04 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Compression fails in Adler32 on a machine that supports SSE3, but not SSSE3 #514

New Issue
Closed
opened 2026-01-29 22:13:09 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:13:09 +00:00
Owner
Copy Link

Originally created by @emz00 on GitHub (Mar 30, 2022).

We're using MongoDB.Driver, which indirectly calls SharpCompress and it fails on a machine with a AMD Opteron(tm) Processor 6176 SE CPU, which supports SSE3, but not SSSE3.

System.PlatformNotSupportedException: Operation is not supported on this platform.
   at System.Runtime.Intrinsics.X86.Ssse3.MultiplyAddAdjacent(Vector128`1 left, Vector128`1 right)
   at SharpCompress.Algorithms.Adler32.CalculateSse(UInt32 adler, ReadOnlySpan`1 buffer)
   at SharpCompress.Algorithms.Adler32.Calculate(UInt32 adler, ReadOnlySpan`1 buffer)
   at SharpCompress.Compressors.Deflate.ZlibCodec.read_buf(Byte[] buf, Int32 start, Int32 size)
   at SharpCompress.Compressors.Deflate.DeflateManager._fillWindow()
   at SharpCompress.Compressors.Deflate.DeflateManager.DeflateSlow(FlushType flush)
   at SharpCompress.Compressors.Deflate.DeflateManager.Deflate(FlushType flush)
   at SharpCompress.Compressors.Deflate.ZlibBaseStream.Write(Byte[] buffer, Int32 offset, Int32 count)
   at MongoDB.Bson.IO.ByteBufferStream.EfficientCopyTo(Stream destination)

This seems to be because the version of Adler32 used by SharpCompress checks for SSE3 and then uses SSSE3:

            if (Sse3.IsSupported && buffer.Length >= MinBufferSize)
            {
                return CalculateSse(adler, buffer); // using SSSE3
            }

This is already fixed in the latest version: https://github.com/SixLabors/ImageSharp/blob/main/src/ImageSharp/Compression/Zlib/Adler32.cs

That checks Ssse3.IsSupported - could you please upgrade to it? That would also fix #645.

Originally created by @emz00 on GitHub (Mar 30, 2022). We're using MongoDB.Driver, which indirectly calls SharpCompress and it fails on a machine with a AMD Opteron(tm) Processor 6176 SE CPU, which supports SSE3, but not SSSE3. ``` System.PlatformNotSupportedException: Operation is not supported on this platform. at System.Runtime.Intrinsics.X86.Ssse3.MultiplyAddAdjacent(Vector128`1 left, Vector128`1 right) at SharpCompress.Algorithms.Adler32.CalculateSse(UInt32 adler, ReadOnlySpan`1 buffer) at SharpCompress.Algorithms.Adler32.Calculate(UInt32 adler, ReadOnlySpan`1 buffer) at SharpCompress.Compressors.Deflate.ZlibCodec.read_buf(Byte[] buf, Int32 start, Int32 size) at SharpCompress.Compressors.Deflate.DeflateManager._fillWindow() at SharpCompress.Compressors.Deflate.DeflateManager.DeflateSlow(FlushType flush) at SharpCompress.Compressors.Deflate.DeflateManager.Deflate(FlushType flush) at SharpCompress.Compressors.Deflate.ZlibBaseStream.Write(Byte[] buffer, Int32 offset, Int32 count) at MongoDB.Bson.IO.ByteBufferStream.EfficientCopyTo(Stream destination) ``` This seems to be because the version of Adler32 used by SharpCompress checks for SSE3 and then uses SSSE3: ``` if (Sse3.IsSupported && buffer.Length >= MinBufferSize) { return CalculateSse(adler, buffer); // using SSSE3 } ``` This is already fixed in the latest version: https://github.com/SixLabors/ImageSharp/blob/main/src/ImageSharp/Compression/Zlib/Adler32.cs That checks `Ssse3.IsSupported` - could you please upgrade to it? That would also fix #645.
claunia added the bugup for grabs labels 2026-01-29 22:13:09 +00:00
claunia commented 2026-01-29 22:13:09 +00:00
Author
Owner
Copy Link

@emz00 commented on GitHub (Mar 30, 2022):

Our version of MongoDB driver is using SharpCompress 0.23 which has a path traversal vulnerability and we cannot upgrade to a patched version due to this issue.

@emz00 commented on GitHub (Mar 30, 2022): Our version of MongoDB driver is using SharpCompress 0.23 which has a [path traversal vulnerability](https://github.com/advisories/GHSA-jp7f-grcv-6mjf) and we cannot upgrade to a patched version due to this issue.
claunia commented 2026-01-29 22:13:10 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Mar 30, 2022):

I would accept a PR. Not sure when I'll have time myself

@adamhathcock commented on GitHub (Mar 30, 2022): I would accept a PR. Not sure when I'll have time myself
claunia commented 2026-01-29 22:13:10 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Mar 30, 2022):

Fix released in https://www.nuget.org/packages/SharpCompress/0.31.0

@adamhathcock commented on GitHub (Mar 30, 2022): Fix released in https://www.nuget.org/packages/SharpCompress/0.31.0
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug up for grabs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#514
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?