starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Create directory when overwrite option is set #533

New Issue
Open
opened 2026-01-29 22:13:25 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 22:13:25 +00:00
Owner
Copy Link

Originally created by @rhuesken on GitHub (Aug 24, 2022).

In 0.32.2, I found that I need to create the "destination" directory first, in order for this call to succeed:

                    reader.WriteEntryToDirectory(destination, new ExtractionOptions()
                    {
                        ExtractFullPath = true,
                        Overwrite = overWrite
                    });

This was working fine with 0.28.2, which creates the "destination" directory if it does not exists. Is this the same issue as #614 ? I have the impression it should have been fixed in 0.29.0... Is that correct?

Originally created by @rhuesken on GitHub (Aug 24, 2022). In 0.32.2, I found that I need to create the "destination" directory first, in order for this call to succeed: reader.WriteEntryToDirectory(destination, new ExtractionOptions() { ExtractFullPath = true, Overwrite = overWrite }); This was working fine with 0.28.2, which creates the "destination" directory if it does not exists. Is this the same issue as #614 ? I have the impression it should have been fixed in 0.29.0... Is that correct?
claunia commented 2026-01-29 22:13:25 +00:00
Author
Owner
Copy Link

@Erior commented on GitHub (Aug 25, 2022):

From what I can see, the 0.29 change checks that you have already created it before calling WriteEntryToDirectory

@Erior commented on GitHub (Aug 25, 2022): From what I can see, the 0.29 change checks that you have already created it before calling WriteEntryToDirectory
claunia commented 2026-01-29 22:13:25 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Sep 6, 2022):

Maybe overwrite should always create the directory. Can't recall the reason for change at the moment

@adamhathcock commented on GitHub (Sep 6, 2022): Maybe overwrite should always create the directory. Can't recall the reason for change at the moment
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#533
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?