starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Compression fails when using a memorystream instead of a filestream #542

New Issue
Closed
opened 2026-01-29 22:13:29 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 22:13:29 +00:00
Owner
Copy Link

Originally created by @DR9885 on GitHub (Nov 24, 2022).

Example Test (based on existing tests)

        [Fact]
        public void TestCompression3()
        {
            string archive = "file.tar";

            // create the 100 char filename
            string filename = "file2.txt";

            // Step 1: create a tar file containing a file with the test name
            using (var stream = new MemoryStream())
            using (var writer = WriterFactory.Open(stream, ArchiveType.Tar, CompressionType.None))
            using (var inputStream = new MemoryStream())
            {
                var input = "dummy filecontent";
                inputStream.Write(Encoding.UTF8.GetBytes(input));

                inputStream.Position = 0;
                writer.Write(filename, inputStream, null);


                // Step 2: check if the written tar file can be read correctly
                using (var archive2 = TarArchive.Open(stream))
                {
                    Assert.Equal(1, archive2.Entries.Count);
                    Assert.Contains(filename, archive2.Entries.Select(entry => entry.Key));

                    foreach (var entry in archive2.Entries)
                    {
                        Assert.Equal("dummy filecontent", new StreamReader(entry.OpenEntryStream()).ReadLine());
                    }
                }
            }

        }
Originally created by @DR9885 on GitHub (Nov 24, 2022). Example Test (based on existing tests) ``` [Fact] public void TestCompression3() { string archive = "file.tar"; // create the 100 char filename string filename = "file2.txt"; // Step 1: create a tar file containing a file with the test name using (var stream = new MemoryStream()) using (var writer = WriterFactory.Open(stream, ArchiveType.Tar, CompressionType.None)) using (var inputStream = new MemoryStream()) { var input = "dummy filecontent"; inputStream.Write(Encoding.UTF8.GetBytes(input)); inputStream.Position = 0; writer.Write(filename, inputStream, null); // Step 2: check if the written tar file can be read correctly using (var archive2 = TarArchive.Open(stream)) { Assert.Equal(1, archive2.Entries.Count); Assert.Contains(filename, archive2.Entries.Select(entry => entry.Key)); foreach (var entry in archive2.Entries) { Assert.Equal("dummy filecontent", new StreamReader(entry.OpenEntryStream()).ReadLine()); } } } } ```
claunia commented 2026-01-29 22:13:29 +00:00
Author
Owner
Copy Link

@DR9885 commented on GitHub (Nov 24, 2022):

Nvm, works when I set the position to zero



        [Fact]
        public void TestCompression3()
        {
            string archive = "file.tar";

            // create the 100 char filename
            string filename = "file2.txt";

            // Step 1: create a tar file containing a file with the test name
            using (var stream = new MemoryStream())
            using (var writer = WriterFactory.Open(stream, ArchiveType.Tar, CompressionType.None))
            using (var inputStream = new MemoryStream())
            {
                var input = "dummy filecontent";
                inputStream.Write(Encoding.UTF8.GetBytes(input));
                inputStream.Position = 0;
                writer.Write(filename, inputStream, null);
                stream.Position = 0;
                inputStream.Position = 0;


                // Step 2: check if the written tar file can be read correctly
                using (var archive2 = TarArchive.Open(stream))
                {
                    Assert.Equal(1, archive2.Entries.Count);
                    Assert.Contains(filename, archive2.Entries.Select(entry => entry.Key));

                    foreach (var entry in archive2.Entries)
                    {
                        Assert.Equal("dummy filecontent", new StreamReader(entry.OpenEntryStream()).ReadLine());
                    }
                }
            }

        }
@DR9885 commented on GitHub (Nov 24, 2022): Nvm, works when I set the position to zero ``` [Fact] public void TestCompression3() { string archive = "file.tar"; // create the 100 char filename string filename = "file2.txt"; // Step 1: create a tar file containing a file with the test name using (var stream = new MemoryStream()) using (var writer = WriterFactory.Open(stream, ArchiveType.Tar, CompressionType.None)) using (var inputStream = new MemoryStream()) { var input = "dummy filecontent"; inputStream.Write(Encoding.UTF8.GetBytes(input)); inputStream.Position = 0; writer.Write(filename, inputStream, null); stream.Position = 0; inputStream.Position = 0; // Step 2: check if the written tar file can be read correctly using (var archive2 = TarArchive.Open(stream)) { Assert.Equal(1, archive2.Entries.Count); Assert.Contains(filename, archive2.Entries.Select(entry => entry.Key)); foreach (var entry in archive2.Entries) { Assert.Equal("dummy filecontent", new StreamReader(entry.OpenEntryStream()).ReadLine()); } } } } ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#542
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?