starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Add support for extensions over r99 (s00, s01... z99) #562

New Issue
Closed
opened 2026-01-29 22:13:46 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:13:46 +00:00
Owner
Copy Link

Originally created by @forkicks on GitHub (Mar 9, 2023).

If a multivolume rar has over 100 volumes, the naming moves from r99 to s00, then up to s99, then t00, so on.

The way the code is set up in RarArchiveVolumeFactory.cs, it will only ever match up to r99, and fail to process more. This makes sharpcompress throw errors when decompressing those large sets of files.

Originally created by @forkicks on GitHub (Mar 9, 2023). If a multivolume rar has over 100 volumes, the naming moves from r99 to s00, then up to s99, then t00, so on. The way the code is set up in RarArchiveVolumeFactory.cs, it will only ever match up to r99, and fail to process more. This makes sharpcompress throw errors when decompressing those large sets of files.
claunia added the enhancementup for grabs labels 2026-01-29 22:13:46 +00:00
claunia commented 2026-01-29 22:13:47 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Mar 10, 2023):

Didn't know it went over 100

@adamhathcock commented on GitHub (Mar 10, 2023): Didn't know it went over 100
claunia commented 2026-01-29 22:13:48 +00:00
Author
Owner
Copy Link

@forkicks commented on GitHub (Mar 10, 2023):

In RarArchiveVolumeFactory.cs, if you add something like:

  m = Regex.Match(part1.Name, @"^(.*\.[stuvwxyz])([0-9]+)$", RegexOptions.IgnoreCase);
                if (m.Success)
                {
                    item = new FileInfo(
                                        Path.Combine(
                                                     part1.DirectoryName!,
                                                     String.Concat(
                                                                   m.Groups[1].Value,
                                                                   (index - 1).ToString().PadLeft(m.Groups[2].Value.Length, '0')
                                                                  )
                                                    )
                                       );
                }

as another else before the "//split .001, .002", it should match the remaining archives (up to z99. I have never seen any real life examples going over it, and I'm unsure how the naming would change after that. Maybe a00?).
I haven't created a pull request to fix this because I'm not familiar enough with the codebase to know if there are side effects of adding change here.
You don't have to change any of the existing conditions or regexes, simply add this one before falling to the 001, 002 test (another if/else).

[edit: typo and code tag]

@forkicks commented on GitHub (Mar 10, 2023): In RarArchiveVolumeFactory.cs, if you add something like: ``` m = Regex.Match(part1.Name, @"^(.*\.[stuvwxyz])([0-9]+)$", RegexOptions.IgnoreCase); if (m.Success) { item = new FileInfo( Path.Combine( part1.DirectoryName!, String.Concat( m.Groups[1].Value, (index - 1).ToString().PadLeft(m.Groups[2].Value.Length, '0') ) ) ); } ``` as another else before the "//split .001, .002", it should match the remaining archives (up to z99. I have never seen any real life examples going over it, and I'm unsure how the naming would change after that. Maybe a00?). I haven't created a pull request to fix this because I'm not familiar enough with the codebase to know if there are side effects of adding change here. You don't have to change any of the existing conditions or regexes, simply add this one before falling to the 001, 002 test (another if/else). [edit: typo and code tag]
claunia commented 2026-01-29 22:13:48 +00:00
Author
Owner
Copy Link

@Erior commented on GitHub (Mar 10, 2023):

If you set WinRAR to generate according to old suffix it will go from z to { and then fail at | because it is not a valid file name in Windows.
The default is currently name.partXXXX.rar

@Erior commented on GitHub (Mar 10, 2023): If you set WinRAR to generate according to old suffix it will go from z to { and then fail at | because it is not a valid file name in Windows. The default is currently name.partXXXX.rar
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label enhancement up for grabs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#562
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?