starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Filename Encoding issue with Tar #581

New Issue
Open
opened 2026-01-29 22:14:07 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:14:07 +00:00
Owner
Copy Link

Originally created by @DisIsAbhi on GitHub (Aug 10, 2023).

Hello, Thanks for working on this repo. Really useful. I have tried to download the Tar file from your Test Archives.

image

If i use var archive= TarArchive.Open(inputFile) and
foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory))
{
entry.WriteToDirectory(outputFolder, new ExtractionOptions()
{
ExtractFullPath = true,
Overwrite = true,
PreserveFileTime = true
}));
}

the output looks like this

image

I have tried ASCII, UNICODE and UTF8 and none of them seem to work.

This begs the question, when opening an archive, how do we make sure that a right ArchiveEncoding is being used?
When we try to open the tar file using 7Zip file manager it is able to display the filename correctly. so if there is anything i am missing with the code here, please let me know.

Originally created by @DisIsAbhi on GitHub (Aug 10, 2023). Hello, Thanks for working on this repo. Really useful. I have tried to download the Tar file from your Test Archives. ![image](https://github.com/adamhathcock/sharpcompress/assets/36386123/ac04a704-e3c0-45f3-9147-70d12de03abc) If i use var archive= TarArchive.Open(inputFile) and foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory)) { entry.WriteToDirectory(outputFolder, new ExtractionOptions() { ExtractFullPath = true, Overwrite = true, PreserveFileTime = true })); } the output looks like this ![image](https://github.com/adamhathcock/sharpcompress/assets/36386123/d14d23ec-a1f9-4829-b9dc-7284b43f78ec) I have tried ASCII, UNICODE and UTF8 and none of them seem to work. This begs the question, when opening an archive, how do we make sure that a right ArchiveEncoding is being used? When we try to open the tar file using 7Zip file manager it is able to display the filename correctly. so if there is anything i am missing with the code here, please let me know.
claunia added the bugquestionup for grabs labels 2026-01-29 22:14:07 +00:00
claunia commented 2026-01-29 22:14:08 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Aug 10, 2023):

Zip file encoding detection needs improving. Setting it manually seems to be a workaround but not great.

@adamhathcock commented on GitHub (Aug 10, 2023): Zip file encoding detection needs improving. Setting it manually seems to be a workaround but not great.
claunia commented 2026-01-29 22:14:08 +00:00
Author
Owner
Copy Link

@DisIsAbhi commented on GitHub (Aug 10, 2023):

Thanks. Surprisingly, i have tried the Dotnet7 implementation of tarreader (thanks for contributing to that as well. I have seen your comments)

FileStream archiveStream = File.Open(inputFile, FileMode.Open, FileAccess.Read);

            using (TarReader reader = new(archiveStream, leaveOpen: true))
            {
                TarEntry? entry;
                while ((entry = reader.GetNextEntry()) != null)
                {
                    if (entry.EntryType != TarEntryType.Directory)
                    {
                        var fname = Path.Join(outputFolder, entry.Name);
                        var dname = Path.GetDirectoryName(fname);
                        if (!Directory.Exists(dname)) Directory.CreateDirectory(dname);
                        Log.Information($"Entry name: {entry.Name}, entry type: {entry.EntryType}");
                        entry.ExtractToFile(destinationFileName: fname, overwrite: false);
                    }
                }
            } 
            
            This also seems to give me the same output as Sharpcompress. the same set of files in other compression formats in your archive test folder seem to work.

This is what i get from 7Zip.BZip2.7z archive you have provided. Thanks
image

@DisIsAbhi commented on GitHub (Aug 10, 2023): Thanks. Surprisingly, i have tried the Dotnet7 implementation of tarreader (thanks for contributing to that as well. I have seen your comments) FileStream archiveStream = File.Open(inputFile, FileMode.Open, FileAccess.Read); using (TarReader reader = new(archiveStream, leaveOpen: true)) { TarEntry? entry; while ((entry = reader.GetNextEntry()) != null) { if (entry.EntryType != TarEntryType.Directory) { var fname = Path.Join(outputFolder, entry.Name); var dname = Path.GetDirectoryName(fname); if (!Directory.Exists(dname)) Directory.CreateDirectory(dname); Log.Information($"Entry name: {entry.Name}, entry type: {entry.EntryType}"); entry.ExtractToFile(destinationFileName: fname, overwrite: false); } } } This also seems to give me the same output as Sharpcompress. the same set of files in other compression formats in your archive test folder seem to work. This is what i get from 7Zip.BZip2.7z archive you have provided. Thanks ![image](https://github.com/adamhathcock/sharpcompress/assets/36386123/c2c8f170-5c54-486a-a81e-f10ba7b85349)
claunia commented 2026-01-29 22:14:08 +00:00
Author
Owner
Copy Link

@DisIsAbhi commented on GitHub (Aug 10, 2023):

Also your repo seems to have filenamedecoder for rar files. do you think it may be useful here?

@DisIsAbhi commented on GitHub (Aug 10, 2023): Also your repo seems to have filenamedecoder for rar files. do you think it may be useful here?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug question up for grabs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#581
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?