starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Checking if a 7z file is encrypted will crash #583

New Issue
Open
opened 2026-01-29 22:14:09 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:14:09 +00:00
Owner
Copy Link

Originally created by @njlr on GitHub (Sep 14, 2023).

Create a 7z file:

$ 7zz a test.7z

Check the entries are encrypted:

Scratch.fsx

#r "nuget: SharpCompress, 0.33.0"

open SharpCompress
open SharpCompress.Archives

let archive = ArchiveFactory.Open("test.7z")

for e in archive.Entries do
  printfn $"IsEncrypted %b{e.IsEncrypted}"

$ dotnet fsi ./Scratch.fsx

It will crash:

System.NullReferenceException: Object reference not set to an instance of an object.
   at SharpCompress.Common.SevenZip.SevenZipFilePart.get_IsEncrypted()
   at SharpCompress.Common.SevenZip.SevenZipEntry.get_IsEncrypted()
Originally created by @njlr on GitHub (Sep 14, 2023). Create a `7z` file: ```bash $ 7zz a test.7z ``` Check the entries are encrypted: `Scratch.fsx` ```fsharp #r "nuget: SharpCompress, 0.33.0" open SharpCompress open SharpCompress.Archives let archive = ArchiveFactory.Open("test.7z") for e in archive.Entries do printfn $"IsEncrypted %b{e.IsEncrypted}" ``` ```bash $ dotnet fsi ./Scratch.fsx ``` It will crash: ``` System.NullReferenceException: Object reference not set to an instance of an object. at SharpCompress.Common.SevenZip.SevenZipFilePart.get_IsEncrypted() at SharpCompress.Common.SevenZip.SevenZipEntry.get_IsEncrypted() ```
claunia commented 2026-01-29 22:14:10 +00:00
Author
Owner
Copy Link

@Erior commented on GitHub (Sep 23, 2023):

To see if I recreated the issue correctly, if you check if it is a directory before checking the IsEncrypted flag
if not e.IsDirectory then
Does that do anything for you?

@Erior commented on GitHub (Sep 23, 2023): To see if I recreated the issue correctly, if you check if it is a directory before checking the IsEncrypted flag `if not e.IsDirectory then` Does that do anything for you?
claunia commented 2026-01-29 22:14:10 +00:00
Author
Owner
Copy Link

@njlr commented on GitHub (Sep 26, 2023):

This does not crash:

#r "nuget: SharpCompress, 0.33.0"

open SharpCompress
open SharpCompress.Archives

let archive = ArchiveFactory.Open("test.7z")

for e in archive.Entries do
  if e.IsDirectory then
    printfn $"%A{e} is a directory"
  else
    printfn $"IsEncrypted %b{e.IsEncrypted}"

Perhaps the error message should be improved?

Can a directory be encrypted?

@njlr commented on GitHub (Sep 26, 2023): This does not crash: ```fsharp #r "nuget: SharpCompress, 0.33.0" open SharpCompress open SharpCompress.Archives let archive = ArchiveFactory.Open("test.7z") for e in archive.Entries do if e.IsDirectory then printfn $"%A{e} is a directory" else printfn $"IsEncrypted %b{e.IsEncrypted}" ``` Perhaps the error message should be improved? Can a directory be encrypted?
claunia commented 2026-01-29 22:14:10 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Sep 26, 2023):

This was fixed: https://github.com/adamhathcock/sharpcompress/pull/768

@adamhathcock commented on GitHub (Sep 26, 2023): This was fixed: https://github.com/adamhathcock/sharpcompress/pull/768
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#583
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?