starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

SharpCompress 0.34.0 does not have a strong name. #587

New Issue
Closed
opened 2026-01-29 22:14:11 +00:00 by claunia · 7 comments
claunia commented 2026-01-29 22:14:11 +00:00
Owner
Copy Link

Originally created by @AptiviCEO on GitHub (Sep 18, 2023).

Hello,

First of all, thank you for your efforts at making this library.

As of the recent update that was released an hour long, SharpCompress 0.34.0 wasn't signed with a strong name, which causes every library that are signed with a strong key to emit warnings that say:

CS8002: Referenced assembly 'SharpCompress, Version=0.34.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

SharpCompress 0.33.0 didn't emit this warning because it was signed. Also, this signing key change wasn't listed in the changelogs.

What is the cause of the lack of signing? I would like this to be fixed.

Thanks!

Originally created by @AptiviCEO on GitHub (Sep 18, 2023). Hello, First of all, thank you for your efforts at making this library. As of the recent update that was released an hour long, SharpCompress 0.34.0 wasn't signed with a strong name, which causes every library that are signed with a strong key to emit warnings that say: ``` CS8002: Referenced assembly 'SharpCompress, Version=0.34.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name. ``` SharpCompress 0.33.0 didn't emit this warning because it was signed. Also, this signing key change wasn't listed in the changelogs. What is the cause of the lack of signing? I would like this to be fixed. Thanks!
claunia commented 2026-01-29 22:14:12 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Sep 18, 2023):

Must be the new dependency for zstd that prevents it as nothing else has been done to stop strong naming

@adamhathcock commented on GitHub (Sep 18, 2023): Must be the new dependency for zstd that prevents it as nothing else has been done to stop strong naming
claunia commented 2026-01-29 22:14:12 +00:00
Author
Owner
Copy Link

@AptiviCEO commented on GitHub (Sep 20, 2023):

OK, thanks. However, it looks like that the zstd port is strong named in the project file:

https://github.com/oleg-st/ZstdSharp/blob/master/src/ZstdSharp/ZstdSharp.csproj

@AptiviCEO commented on GitHub (Sep 20, 2023): OK, thanks. However, it looks like that the zstd port is strong named in the project file: https://github.com/oleg-st/ZstdSharp/blob/master/src/ZstdSharp/ZstdSharp.csproj
claunia commented 2026-01-29 22:14:13 +00:00
Author
Owner
Copy Link

@caesay commented on GitHub (Nov 4, 2023):

For now, seems 0.33.0 is the last release that can be used on the full framework because of this issue. 34.0 and 34.1 both fail due to strong name issues. This is not a problem in dotnet (core) because strong names are not checked.

@caesay commented on GitHub (Nov 4, 2023): For now, seems 0.33.0 is the last release that can be used on the full framework because of this issue. 34.0 and 34.1 both fail due to strong name issues. This is not a problem in dotnet (core) because strong names are not checked.
claunia commented 2026-01-29 22:14:13 +00:00
Author
Owner
Copy Link

@AlexVallat commented on GitHub (Nov 9, 2023):

Looks like <SignAssembly> was changed to false in SharpCompress.csproj, but was this deliberate for some reason?

@AlexVallat commented on GitHub (Nov 9, 2023): Looks like `<SignAssembly>` was changed to `false` in SharpCompress.csproj, but was this deliberate for some reason?
claunia commented 2026-01-29 22:14:13 +00:00
Author
Owner
Copy Link

@caesay commented on GitHub (Nov 14, 2023):

I've opened #780 to address this.

@caesay commented on GitHub (Nov 14, 2023): I've opened #780 to address this.
claunia commented 2026-01-29 22:14:13 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Nov 15, 2023):

Merged that and deployed https://www.nuget.org/packages/SharpCompress/0.34.2 to fix by @caesay

@adamhathcock commented on GitHub (Nov 15, 2023): Merged that and deployed https://www.nuget.org/packages/SharpCompress/0.34.2 to fix by @caesay
claunia commented 2026-01-29 22:14:13 +00:00
Author
Owner
Copy Link

@AptiviCEO commented on GitHub (Nov 15, 2023):

I updated this library and I no longer have this issue. Thanks @adamhathcock and @caesay!

@AptiviCEO commented on GitHub (Nov 15, 2023): I updated this library and I no longer have this issue. Thanks @adamhathcock and @caesay!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#587
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?