mirror of
https://github.com/adamhathcock/sharpcompress.git
synced 2026-02-03 21:23:38 +00:00
.NET Native building failed #604
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @wherewhere on GitHub (Jan 1, 2024).
Build succeed with 0.33.0, but failed with 0.35.0.
0ac335f9a4@Erior commented on GitHub (Jan 2, 2024):
As far as I know that is a tool chain error, I checked out the project, sharpcompress indicated 0.35 and it built just fine for me.
VS 17.8.3 if that helps.
@zhuxb711 commented on GitHub (Jan 16, 2024):
The last available one is 0.33.0, ZstdSharp.Port introduced from 0.34.0 will break the .Net Native
@adamhathcock commented on GitHub (Jan 16, 2024):
Do you know what causes it?
We could move the code to be internal to library
@schouffy commented on GitHub (Apr 23, 2024):
I have the same issue, I can confirm 0.33 is the latest version that builds on .net native toolchain (which is required for MS Store :( ).
That's for UWP at least.
@adamhathcock commented on GitHub (Apr 24, 2024):
I'm gonna need some kind of error message or stacktrace.
It's probably the ZstdSharp dependency and I'm loathed to embed it.
@schouffy commented on GitHub (Apr 24, 2024):
I'll send you the .net native compilation verbose log tonight. But it won't be super helpful I think, the only relevant information (as far as I can tell) is the error message sent by OP.
@adamhathcock commented on GitHub (Apr 24, 2024):
well, it's probably the dependency then. I don't know anything about .net native to make it worthwhile to get the whole log if you say there's nothing useful
@oleg-st commented on GitHub (Apr 24, 2024):
Added a workaround for .NET Native in ZstdSharp 0.8.0
@adamhathcock commented on GitHub (Apr 25, 2024):
49ce17b759I've updated ZstdSharp and made NET8 only trimmable
@zhuxb711 commented on GitHub (Apr 25, 2024):
Should use contains? More target framework belongs to .net8.0, such as .net8.0-windows / .net8.0-windows10.0.19041.0
@adamhathcock commented on GitHub (Apr 25, 2024):
the more specific targets still output their base framework: https://github.com/dotnet/designs/blob/main/accepted/2020/net5/net5.md#mapping-to-properties
@schouffy commented on GitHub (Apr 25, 2024):
You guys rock!
@schouffy commented on GitHub (Jun 4, 2024):
I have updated to 0.37.2 and I can confirme that it now builds fine using the .net native toolchain. Thanks!