starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

ReaderFactory not iterating over big entries #606

New Issue
Closed
opened 2026-01-29 22:14:28 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 22:14:28 +00:00
Owner
Copy Link

Originally created by @jbrockerville on GitHub (Jan 2, 2024).

I've encountered an issue with the ReaderFactory and ZIP archives with "big" entries. If an archive has a sufficiently big enough entry, the reader fails to iterate over all the entries. No error. Just no next entry and drops out of the loop. The ArchiveFactory seems fine. Please see the attached code for generating the archive ("data/data.py") and reproducing the bug. Here is the output I get:

Entries via ReaderFactory...
  bin1.bin
Entries via ArchiveFactory...
  bin1.bin
  a.txt
  c.txt

BigArchive.zip

Originally created by @jbrockerville on GitHub (Jan 2, 2024). I've encountered an issue with the `ReaderFactory` and ZIP archives with "big" entries. If an archive has a sufficiently big enough entry, the reader fails to iterate over all the entries. No error. Just no next entry and drops out of the loop. The `ArchiveFactory` seems fine. Please see the attached code for generating the archive ("data/data.py") and reproducing the bug. Here is the output I get: ``` Entries via ReaderFactory... bin1.bin Entries via ArchiveFactory... bin1.bin a.txt c.txt ``` [BigArchive.zip](https://github.com/adamhathcock/sharpcompress/files/13814299/BigArchive.zip)
claunia added the bugup for grabs labels 2026-01-29 22:14:28 +00:00
claunia commented 2026-01-29 22:14:28 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jan 8, 2024):

Maybe https://github.com/adamhathcock/sharpcompress/pull/799 will address

@adamhathcock commented on GitHub (Jan 8, 2024): Maybe https://github.com/adamhathcock/sharpcompress/pull/799 will address
claunia commented 2026-01-29 22:14:28 +00:00
Author
Owner
Copy Link

@DannyBoyk commented on GitHub (Jan 29, 2024):

Latest SharpCompress code produces identical results for ReaderFactory and ArchiveFactory, so it appears this can be closed out.

@DannyBoyk commented on GitHub (Jan 29, 2024): Latest SharpCompress code produces identical results for ReaderFactory and ArchiveFactory, so it appears this can be closed out.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug up for grabs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#606
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?