starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-07 05:34:35 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

ZIP: Use last modified time from basic header when validating zip decryption #613

New Issue
Closed
opened 2026-01-29 22:14:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:14:38 +00:00
Owner
Copy Link

Originally created by @DannyBoyk on GitHub (Jan 26, 2024).

When support was added for the UnixTimeExtraField a little while ago, zip decryption validation was broken if a zip is encrypted and has UnixTimeExtraFields present. The zip encryption uses the basic header's last modified time value and not the times from the UnixTimeExtraField.

PR to fix incoming.

Originally created by @DannyBoyk on GitHub (Jan 26, 2024). When support was added for the UnixTimeExtraField a little while ago, zip decryption validation was broken if a zip is encrypted and has UnixTimeExtraFields present. The zip encryption uses the basic header's last modified time value and not the times from the UnixTimeExtraField. PR to fix incoming.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#613
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?