starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

RAR archive mistaken as Tar archive #64

New Issue
Closed
opened 2026-01-29 22:06:04 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 22:06:04 +00:00
Owner
Copy Link

Originally created by @elgonzo on GitHub (Sep 7, 2015).

SharpCompress will not open and read the following RAR file correctly:

RAR file download link:http://wikisend.com/download/295490/RAR_identified_as_Tar.rar
Password: adamhathcock
(The download link expires after 90 days!)

The RAR archive is NOT in RAR5 format, and it contains only one file "PROTONIX.D64".

ArchiveFactory.Open(...) will return a SharpCompress.Archive.Tar.TarArchive instance for this RAR file.
And ReaderFactory.Open(...) will return a SharpCompress.Reader.Tar.TarReader.

SharpCompress version used: 0.11.1

Originally created by @elgonzo on GitHub (Sep 7, 2015). SharpCompress will not open and read the following RAR file correctly: RAR file download link:http://wikisend.com/download/295490/RAR_identified_as_Tar.rar Password: adamhathcock (**The download link expires after 90 days!**) The RAR archive is **NOT** in RAR5 format, and it contains only one file "PROTONIX.D64". _ArchiveFactory.Open(...)_ will return a _SharpCompress.Archive.Tar.TarArchive_ instance for this RAR file. And _ReaderFactory.Open(...)_ will return a _SharpCompress.Reader.Tar.TarReader_. SharpCompress version used: 0.11.1
claunia commented 2026-01-29 22:06:05 +00:00
Author
Owner
Copy Link

@elgonzo commented on GitHub (Sep 7, 2015):

I guess the file format check should be changed so that Tar is tested after other archive format tests such as RAR, 7z, GZip, etc...

In ArchiveFactory: https://github.com/adamhathcock/sharpcompress/blob/master/SharpCompress/Archive/ArchiveFactory.cs#L129
In ReaderFactory: https://github.com/adamhathcock/sharpcompress/blob/master/SharpCompress/Reader/ReaderFactory.cs#L65

@elgonzo commented on GitHub (Sep 7, 2015): I guess the file format check should be changed so that Tar is tested **after** other archive format tests such as RAR, 7z, GZip, etc... In ArchiveFactory: https://github.com/adamhathcock/sharpcompress/blob/master/SharpCompress/Archive/ArchiveFactory.cs#L129 In ReaderFactory: https://github.com/adamhathcock/sharpcompress/blob/master/SharpCompress/Reader/ReaderFactory.cs#L65
claunia commented 2026-01-29 22:06:05 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jan 9, 2016):

Did your suggestion: 21087323af

@adamhathcock commented on GitHub (Jan 9, 2016): Did your suggestion: https://github.com/adamhathcock/sharpcompress/commit/21087323af2caa5cfb394eee30ecd919b68421c6
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#64
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?