starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

compatibility with non-standard zip formats #651

New Issue
Closed
opened 2026-01-29 22:15:19 +00:00 by claunia · 3 comments
claunia commented 2026-01-29 22:15:19 +00:00
Owner
Copy Link

Originally created by @Qeynos on GitHub (Aug 8, 2024).

I have an old zip file that may not have been created following the standard specifications. When I use SharpCompress to decompress it, the backslash character is merged with the file name, causing the extracted files to have incorrect paths, such as "/home/test/storage\first\error.jpg". I need to use code like this to solve the problem. I wonder if there has been any consideration for compatibility with non-standard zip formats.

    var opts = new ReaderOptions();
    var encoding = Encoding.GetEncoding(936);
    opts.ArchiveEncoding = new ArchiveEncoding
    {
        CustomDecoder = (data, x, y) =>
    {
        return encoding.GetString(data);
    }
    };
    var archive = ZipArchive.Open(archiveFilePath, opts);
    foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory))
    {
        string? fileName = entry.Key;
        string updatedPath = fileName.Replace('\\', '/');
        string filePath = Path.Combine(outputDirectoryPath, updatedPath);
        if (!Directory.Exists(Path.GetDirectoryName(filePath)))
        {
            Directory.CreateDirectory(Path.GetDirectoryName(filePath));
        }
        entry.WriteToFile(filePath);
    }
Originally created by @Qeynos on GitHub (Aug 8, 2024). I have an old zip file that may not have been created following the standard specifications. When I use SharpCompress to decompress it, the backslash character is merged with the file name, causing the extracted files to have incorrect paths, such as "/home/test/storage\first\error.jpg". I need to use code like this to solve the problem. I wonder if there has been any consideration for compatibility with non-standard zip formats. > var opts = new ReaderOptions(); > var encoding = Encoding.GetEncoding(936); > opts.ArchiveEncoding = new ArchiveEncoding > { > CustomDecoder = (data, x, y) => > { > return encoding.GetString(data); > } > }; > var archive = ZipArchive.Open(archiveFilePath, opts); > foreach (var entry in archive.Entries.Where(entry => !entry.IsDirectory)) > { > string? fileName = entry.Key; > string updatedPath = fileName.Replace('\\', '/'); > string filePath = Path.Combine(outputDirectoryPath, updatedPath); > if (!Directory.Exists(Path.GetDirectoryName(filePath))) > { > Directory.CreateDirectory(Path.GetDirectoryName(filePath)); > } > entry.WriteToFile(filePath); > }
claunia commented 2026-01-29 22:15:20 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Aug 8, 2024):

the slashes are just the key name and is OS independent really. The Path.Separator should be OS specific and could be used to figure that out but not everyone wants the keys to be automatically converted.

@adamhathcock commented on GitHub (Aug 8, 2024): the slashes are just the key name and is OS independent really. The Path.Separator should be OS specific and could be used to figure that out but not everyone wants the keys to be automatically converted.
claunia commented 2026-01-29 22:15:20 +00:00
Author
Owner
Copy Link

@Qeynos commented on GitHub (Aug 8, 2024):

In Linux, the 'storage\first\error.jpg' in a non-standard zip file is considered to be a filename without a path. Even if you use Path.Combine to combine entry.Key with the path, it will not correct this error.

@Qeynos commented on GitHub (Aug 8, 2024): In Linux, the 'storage\first\error.jpg' in a non-standard zip file is considered to be a filename without a path. Even if you use Path.Combine to combine entry.Key with the path, it will not correct this error.
claunia commented 2026-01-29 22:15:21 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Aug 12, 2024):

Like I said, this is a key that is the same on all platforms with those slashes....a zip is a series of key/values.

The slash being different across platforms is an implementation detail you need to fix yourself or use a helper method to convert them.

@adamhathcock commented on GitHub (Aug 12, 2024): Like I said, this is a key that is the same on all platforms with those slashes....a zip is a series of key/values. The slash being different across platforms is an implementation detail you need to fix yourself or use a helper method to convert them.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#651
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?