starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-13 13:35:28 +00:00
Code Issues 975 Packages Projects Releases 23 Wiki Activity

Padding calculation wrong when starting position % 4 != 0 #663

New Issue
Closed
opened 2026-01-29 22:15:28 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 22:15:28 +00:00
Owner
Copy Link

Originally created by @5andr0 on GitHub (Sep 25, 2024).

private void SkipPadding()
    {
        var bytes = (int)(BaseStream.Position % 4);

I have a BaseStream where the xz file doesn't start at position 0. If this position is not dividable by 4, then the padding calculation is wrong.
Please fix this by calculating the position from the starting position.
Thanks

Originally created by @5andr0 on GitHub (Sep 25, 2024). ``` private void SkipPadding() { var bytes = (int)(BaseStream.Position % 4); ``` I have a BaseStream where the xz file doesn't start at position 0. If this position is not dividable by 4, then the padding calculation is wrong. Please fix this by calculating the position from the starting position. Thanks
claunia added the bugup for grabs labels 2026-01-29 22:15:28 +00:00
claunia commented 2026-01-29 22:15:29 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Sep 26, 2024):

PRs are welcome

@adamhathcock commented on GitHub (Sep 26, 2024): PRs are welcome
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug up for grabs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#663
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?