starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

XZ decompression doesn't like SHA-256 checksums #676

New Issue
Closed
opened 2026-01-29 22:15:42 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 22:15:42 +00:00
Owner
Copy Link

Originally created by @ms264556 on GitHub (Mar 7, 2025).

I think, since the XZ code doesn't actually run an block checksums, the fix would simply be skipping the correct number of bytes?

PR is here: https://github.com/adamhathcock/sharpcompress/pull/901.

Originally created by @ms264556 on GitHub (Mar 7, 2025). I think, since the XZ code doesn't actually run an block checksums, the fix would simply be skipping the correct number of bytes? PR is here: [https://github.com/adamhathcock/sharpcompress/pull/901](https://github.com/adamhathcock/sharpcompress/pull/901).
claunia commented 2026-01-29 22:15:43 +00:00
Author
Owner
Copy Link

@ms264556 commented on GitHub (Mar 7, 2025):

Actually, by reference to section 2.1.1.2 of the specification, the number of bytes formula just needs a tweak (since it currently returns 16 bytes for SHA-256 and should return 32).

I'll update my PR with the formula.

@ms264556 commented on GitHub (Mar 7, 2025): Actually, by reference to section 2.1.1.2 of [the specification](https://tukaani.org/xz/xz-file-format.txt), the number of bytes formula just needs a tweak (since it currently returns 16 bytes for SHA-256 and should return 32). I'll update my PR with the formula.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#676
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?