starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

ExtractToDirectory has missing files when working with encrypted zip files which contain directories #698

New Issue
Closed
opened 2026-01-29 22:16:04 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 22:16:04 +00:00
Owner
Copy Link

Originally created by @aaronbarak666-art on GitHub (Aug 19, 2025).

Created an encrypted zip file using 7zip with the following structure:

TestDirectory\a.txt
TestDirectory\b.txt

The following code only extracts a.txt:

using IArchive archive = ArchiveFactory.Open(zipPath, new ReaderOptions() { Password = "test" } );
archive.ExtractToDirectory(outputPath)

Zip files without a password, or without directories seem to work ok
Also 7z files work.

This seems to be an issue with ExtractAllEntries, since this test case works on version 0.38.0, when I use WriteToDirectory instead.
This does break again in 0.40.0, because of #900 which made WriteToDirectory use ExtractAllEntries

Originally created by @aaronbarak666-art on GitHub (Aug 19, 2025). Created an encrypted **zip** file using 7zip with the following structure: ``` TestDirectory\a.txt TestDirectory\b.txt ``` The following code only extracts `a.txt`: ``` using IArchive archive = ArchiveFactory.Open(zipPath, new ReaderOptions() { Password = "test" } ); archive.ExtractToDirectory(outputPath) ``` **Zip** files without a password, or without directories seem to work ok Also **7z** files work. This seems to be an issue with `ExtractAllEntries`, since this test case works on version `0.38.0`, when I use `WriteToDirectory` instead. This does break again in `0.40.0`, because of #900 which made `WriteToDirectory` use `ExtractAllEntries`
claunia commented 2026-01-29 22:16:05 +00:00
Author
Owner
Copy Link

@Morilli commented on GitHub (Aug 20, 2025):

Can't reproduce on either latest master or with version 0.40.0 using the same code and the following test archive: TestDirectory.zip

Does this only happen with specific zip files? Could you share an example file?

@Morilli commented on GitHub (Aug 20, 2025): Can't reproduce on either latest master or with version `0.40.0` using the same code and the following test archive: [TestDirectory.zip](https://github.com/user-attachments/files/21899941/TestDirectory.zip) Does this only happen with specific zip files? Could you share an example file?
claunia commented 2026-01-29 22:16:06 +00:00
Author
Owner
Copy Link

@aaronbarak666-art commented on GitHub (Aug 21, 2025):

I've tried your file and it did work.
I did manage to reproduce it again with very small text files (one character). Maybe it's connected to the compression method?
Small files are compressed in 7-zip as AES-256 Store instead of AES-256 Deflate
Here's an example for a non-working zip file
TestDirectory.zip

@aaronbarak666-art commented on GitHub (Aug 21, 2025): I've tried your file and it did work. I did manage to reproduce it again with very small text files (one character). Maybe it's connected to the compression method? Small files are compressed in 7-zip as `AES-256 Store` instead of `AES-256 Deflate` Here's an example for a non-working zip file [TestDirectory.zip](https://github.com/user-attachments/files/21914651/TestDirectory.zip)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#698
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?