starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Exception when disposing RarArchive #718

New Issue
Closed
opened 2026-01-29 22:16:21 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:16:21 +00:00
Owner
Copy Link

Originally created by @RawScape on GitHub (Nov 15, 2025).

Originally assigned to: @Copilot on GitHub.

I ran into an exception when disposing RarArchive after processing a damaged archive.

System.ArgumentNullException: Value cannot be null. (Parameter 'array')
   at System.Buffers.SharedArrayPool`1.Return(T[] array, Boolean clearArray)
   at SharpCompress.Compressors.Rar.UnpackV1.Unpack.Dispose() in /_/SharpCompress/Compressors/Rar/UnpackV1/Unpack.cs:line 32
   at SharpCompress.Archives.Rar.RarArchive.Dispose() in /_/SharpCompress/Archives/Rar/RarArchive.cs:line 35

I checked in SharpCompress.Compressors.Rar.UnpackV1.Unpack and found:

public override void Dispose()
{
    if (!disposed)
    {
        base.Dispose();
        if (!externalWindow)
        {
            ArrayPool<byte>.Shared.Return(window);
            window = null;
        }
        rarVM.Dispose();
        disposed = true;
    }
}

since "window" was "null" at this point I added a check fo this:

public override void Dispose()
{
    if (!disposed)
    {
        base.Dispose();
        if (!externalWindow && window is not null)
        {
            ArrayPool<byte>.Shared.Return(window);
            window = null;
        }
        rarVM.Dispose();
        disposed = true;
    }
}
Originally created by @RawScape on GitHub (Nov 15, 2025). Originally assigned to: @Copilot on GitHub. I ran into an exception when disposing RarArchive after processing a damaged archive. ``` System.ArgumentNullException: Value cannot be null. (Parameter 'array') at System.Buffers.SharedArrayPool`1.Return(T[] array, Boolean clearArray) at SharpCompress.Compressors.Rar.UnpackV1.Unpack.Dispose() in /_/SharpCompress/Compressors/Rar/UnpackV1/Unpack.cs:line 32 at SharpCompress.Archives.Rar.RarArchive.Dispose() in /_/SharpCompress/Archives/Rar/RarArchive.cs:line 35 ``` I checked in SharpCompress.Compressors.Rar.UnpackV1.Unpack and found: ``` public override void Dispose() { if (!disposed) { base.Dispose(); if (!externalWindow) { ArrayPool<byte>.Shared.Return(window); window = null; } rarVM.Dispose(); disposed = true; } } ``` since "window" was "null" at this point I added a check fo this: ``` public override void Dispose() { if (!disposed) { base.Dispose(); if (!externalWindow && window is not null) { ArrayPool<byte>.Shared.Return(window); window = null; } rarVM.Dispose(); disposed = true; } } ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#718
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?