starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Regression: ArchiveFactory.IsArchive throws on non archive files in 0.42.0 #742

New Issue
Closed
opened 2026-01-29 22:16:44 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 22:16:44 +00:00
Owner
Copy Link

Originally created by @ImoutoChan on GitHub (Dec 7, 2025).

Originally assigned to: @Copilot on GitHub.

Version: 0.42.0

Calling ArchiveFactory.IsArchive on simple non-archive file throws InvalidDataException.
Works fine on 0.41.0

System.IO.InvalidDataException: Not an ARJ file (wrong magic bytes)
   at SharpCompress.Common.Arj.Headers.ArjHeader.ReadHeader(Stream stream) in /_/src/SharpCompress/Common/Arj/Headers/ArjHeader.cs:line 46
   at SharpCompress.Common.Arj.Headers.ArjMainHeader.Read(Stream stream) in /_/src/SharpCompress/Common/Arj/Headers/ArjMainHeader.cs:line 43
   at SharpCompress.Factories.ArjFactory.IsArchive(Stream stream, String password, Int32 bufferSize) in /_/src/SharpCompress/Factories/ArjFactory.cs:line 32
   at SharpCompress.Archives.ArchiveFactory.IsArchive(Stream stream, Nullable`1& type, Int32 bufferSize) in /_/src/SharpCompress/Archives/ArchiveFactory.cs:line 198
   at SharpCompress.Archives.ArchiveFactory.IsArchive(String filePath, Nullable`1& type, Int32 bufferSize) in /_/src/SharpCompress/Archives/ArchiveFactory.cs:line 177
Originally created by @ImoutoChan on GitHub (Dec 7, 2025). Originally assigned to: @Copilot on GitHub. Version: 0.42.0 Calling ArchiveFactory.IsArchive on simple non-archive file throws InvalidDataException. Works fine on 0.41.0 ``` System.IO.InvalidDataException: Not an ARJ file (wrong magic bytes) at SharpCompress.Common.Arj.Headers.ArjHeader.ReadHeader(Stream stream) in /_/src/SharpCompress/Common/Arj/Headers/ArjHeader.cs:line 46 at SharpCompress.Common.Arj.Headers.ArjMainHeader.Read(Stream stream) in /_/src/SharpCompress/Common/Arj/Headers/ArjMainHeader.cs:line 43 at SharpCompress.Factories.ArjFactory.IsArchive(Stream stream, String password, Int32 bufferSize) in /_/src/SharpCompress/Factories/ArjFactory.cs:line 32 at SharpCompress.Archives.ArchiveFactory.IsArchive(Stream stream, Nullable`1& type, Int32 bufferSize) in /_/src/SharpCompress/Archives/ArchiveFactory.cs:line 198 at SharpCompress.Archives.ArchiveFactory.IsArchive(String filePath, Nullable`1& type, Int32 bufferSize) in /_/src/SharpCompress/Archives/ArchiveFactory.cs:line 177 ```
claunia added the bug label 2026-01-29 22:16:44 +00:00
claunia commented 2026-01-29 22:16:45 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Dec 8, 2025):

Should be fixed in 0.42.1

@adamhathcock commented on GitHub (Dec 8, 2025): Should be fixed in 0.42.1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#742
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?