starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

WriteToDirectory v ExtractToDirectory consistency #744

New Issue
Closed
opened 2026-01-29 22:16:47 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:16:47 +00:00
Owner
Copy Link

Originally created by @adamhathcock on GitHub (Dec 19, 2025).

Originally assigned to: @adamhathcock, @Copilot on GitHub.

The static method WriteToDirectory now internally calls ExtractToDirectory, which creates a naming inconsistency. Consider either renaming the public method to ExtractToDirectory for consistency, or documenting why WriteToDirectory internally uses ExtractToDirectory to help future maintainers understand the design choice.

I like WriteToDirectory (and async variants) but unsure of ExtractToDirectory.

ExtractToDirectory should probably be removed in favor of things named WriteToDirectory.

All archive and reader types need to have WriteTo options via itself or a parent class

Originally created by @adamhathcock on GitHub (Dec 19, 2025). Originally assigned to: @adamhathcock, @Copilot on GitHub. The static method WriteToDirectory now internally calls ExtractToDirectory, which creates a naming inconsistency. Consider either renaming the public method to ExtractToDirectory for consistency, or documenting why WriteToDirectory internally uses ExtractToDirectory to help future maintainers understand the design choice. I like WriteToDirectory (and async variants) but unsure of ExtractToDirectory. ExtractToDirectory should probably be removed in favor of things named WriteToDirectory. All archive and reader types need to have WriteTo options via itself or a parent class
claunia added the enhancement label 2026-01-29 22:16:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?