starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-08 21:21:57 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Handled System.NotSupportedException but can be avoided? #745

New Issue
Closed
opened 2026-01-29 22:16:47 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:16:47 +00:00
Owner
Copy Link

Originally created by @sherlock1982 on GitHub (Dec 22, 2025).

Originally assigned to: @adamhathcock, @Copilot on GitHub.

Open xz file like this:

            using var fileStream = new FileStream(updateFilename, FileMode.Open, FileAccess.Read);
            using var reader = ReaderFactory.Open(fileStream, new SharpCompress.Readers.ReaderOptions()
            {
                LeaveStreamOpen = true,
            });

SharpCompressStream is wrapped around ReadOnlyStream and ReadOnlyStream doesnt' support Position get. In SharpCompressStream exception is handled:

    try
    {
        _baseInitialPos = stream.Position;
    }
    catch
    {
        _baseInitialPos = 0;
    }

But this is still exception thrown for each entry I think which causes performance issues. Can it be avoided? Check for CanSeek ?

Originally created by @sherlock1982 on GitHub (Dec 22, 2025). Originally assigned to: @adamhathcock, @Copilot on GitHub. Open xz file like this: using var fileStream = new FileStream(updateFilename, FileMode.Open, FileAccess.Read); using var reader = ReaderFactory.Open(fileStream, new SharpCompress.Readers.ReaderOptions() { LeaveStreamOpen = true, }); `SharpCompressStream` is wrapped around `ReadOnlyStream` and `ReadOnlyStream` doesnt' support Position get. In `SharpCompressStream` exception is handled: try { _baseInitialPos = stream.Position; } catch { _baseInitialPos = 0; } But this is still exception thrown for each entry I think which causes performance issues. Can it be avoided? Check for `CanSeek` ?
claunia added the bug label 2026-01-29 22:16:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#745
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?