starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

the zip file with '\\' in it's entry.Key make error when run in linux #755

New Issue
Closed
opened 2026-01-29 22:17:07 +00:00 by claunia · 5 comments
claunia commented 2026-01-29 22:17:07 +00:00
Owner
Copy Link

Originally created by @jackletter on GitHub (Jan 7, 2026).

Although the zip specification stipulates that file path names should use '/' as the separator, there are still non-compliant writes that can cause issues when extracting on Linux. Could we consider uniformly replacing '' with '/' after decoding?

Additional note: I tried implementing the replacement in the CustomDecoder, but if the zip file specifies an encoding, SharpCompress won't invoke the CustomDecoder, preventing me from making the corrections.

        if (Flags.HasFlag(HeaderFlags.Efs))
        {
            Name = ArchiveEncoding.DecodeUTF8(name);
            Comment = ArchiveEncoding.DecodeUTF8(comment);
        }
        else
        {
            Name = ArchiveEncoding.Decode(name);
            Comment = ArchiveEncoding.Decode(comment);
        }
Originally created by @jackletter on GitHub (Jan 7, 2026). Although the zip specification stipulates that file path names should use '/' as the separator, there are still non-compliant writes that can cause issues when extracting on Linux. Could we consider uniformly replacing '\' with '/' after decoding? Additional note: I tried implementing the replacement in the CustomDecoder, but if the zip file specifies an encoding, SharpCompress won't invoke the CustomDecoder, preventing me from making the corrections. ```csharp if (Flags.HasFlag(HeaderFlags.Efs)) { Name = ArchiveEncoding.DecodeUTF8(name); Comment = ArchiveEncoding.DecodeUTF8(comment); } else { Name = ArchiveEncoding.Decode(name); Comment = ArchiveEncoding.Decode(comment); } ```
claunia commented 2026-01-29 22:17:08 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jan 7, 2026):

It something making a zip with \ in the path in SharpCompress? If something is doing this, I don't want to account for it with code.

Maybe the encoding method should have more options?

@adamhathcock commented on GitHub (Jan 7, 2026): It something making a zip with `\` in the path in SharpCompress? If something is doing this, I don't want to account for it with code. Maybe the encoding method should have more options?
claunia commented 2026-01-29 22:17:08 +00:00
Author
Owner
Copy Link

@jackletter commented on GitHub (Jan 7, 2026):

Users may use various programs to compress ZIP file packages, which is beyond our control. As a service provider, we must strive to be as compatible as possible with users' files. @adamhathcock

@jackletter commented on GitHub (Jan 7, 2026): Users may use various programs to compress ZIP file packages, which is beyond our control. As a service provider, we must strive to be as compatible as possible with users' files. @adamhathcock
claunia commented 2026-01-29 22:17:08 +00:00
Author
Owner
Copy Link

@jackletter commented on GitHub (Jan 7, 2026):

The simplest approach is to make the ArchiveEncoding.DecodeUTF8 method virtual. This way, I can inherit from ArchiveEncoding and override DecodeUTF8 to internally replace '\' with '/'.

@jackletter commented on GitHub (Jan 7, 2026): The simplest approach is to make the ArchiveEncoding.DecodeUTF8 method virtual. This way, I can inherit from ArchiveEncoding and override DecodeUTF8 to internally replace '\\' with '/'.
claunia commented 2026-01-29 22:17:08 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jan 7, 2026):

Users may use various programs to compress ZIP file packages, which is beyond our control. As a service provider, we must strive to be as compatible as possible with users' files. @adamhathcock

Disagree. Keys are dumb strings and whatever produces should confirm to spec. If the programs don't, it's not up to SharpCompress to fix it. People can do things themselves with SC though.

The simplest approach is to make the ArchiveEncoding.DecodeUTF8 method virtual. This way, I can inherit from ArchiveEncoding and override DecodeUTF8 to internally replace '' with '/'.

It is the simplest, however might not be the best.

@adamhathcock commented on GitHub (Jan 7, 2026): > Users may use various programs to compress ZIP file packages, which is beyond our control. As a service provider, we must strive to be as compatible as possible with users' files. [@adamhathcock](https://github.com/adamhathcock) Disagree. Keys are dumb strings and whatever produces should confirm to spec. If the programs don't, it's not up to SharpCompress to fix it. People can do things themselves with SC though. > The simplest approach is to make the ArchiveEncoding.DecodeUTF8 method virtual. This way, I can inherit from ArchiveEncoding and override DecodeUTF8 to internally replace '\' with '/'. It is the simplest, however might not be the best.
claunia commented 2026-01-29 22:17:09 +00:00
Author
Owner
Copy Link

@jackletter commented on GitHub (Jan 7, 2026):

So please merge the pull request, so I won't have to duplicate SharpCompress source code internally.

@jackletter commented on GitHub (Jan 7, 2026): So please merge the pull request, so I won't have to duplicate SharpCompress source code internally.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#755
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?