starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Iterating TarArchive.Entries fails if EntryStream.CopyToAsync called #77

New Issue
Open
opened 2026-01-29 22:06:15 +00:00 by claunia · 4 comments
claunia commented 2026-01-29 22:06:15 +00:00
Owner
Copy Link

Originally created by @matthewDDennis on GitHub (Jan 18, 2016).

The following code fails if the archive.Entries.ToList() is changed to archive.Entries. I suspect that there is interaction with the streams. So calling ToList() prevents this as the Enumeration of the Entries will complete its use of the stream.

using (var fileStream = fileinfo.OpenRead())
{
    using (var gzipStream = new GZipStream(fileStream, CompressionMode.Decompress))
    {
        using (var memStream = new MemoryStream())
        {
            await gzipStream.CopyToAsync(memStream);
            memStream.Position = 0;
            using (var archive = SharpCompress.Archive.Tar.TarArchive.Open(memStream))
            {
                foreach (var entry in archive.Entries.ToList())
                {
                    if (!entry.IsDirectory && entry.Key.EndsWith(".json"))
                    {
                        var outputFileName = $"{dataDir.FullName}\\{entry.Key.Substring(2)}";
                        Console.WriteLine($"Extracting {outputFileName}");

                        var outputFile = new FileInfo(outputFileName);
                        using (var outputStream = outputFile.OpenWrite())
                        {
                            using (var entryStream = entry.OpenEntryStream())
                            {
                                await entryStream.CopyToAsync(outputStream);
                            }
                        }
                    }
                }
            }
            Console.WriteLine($"Opened file {fileinfo.FullName}");
        }
    }
Originally created by @matthewDDennis on GitHub (Jan 18, 2016). The following code fails if the `archive.Entries.ToList()` is changed to `archive.Entries`. I suspect that there is interaction with the streams. So calling `ToList()` prevents this as the Enumeration of the Entries will complete its use of the stream. ``` c# using (var fileStream = fileinfo.OpenRead()) { using (var gzipStream = new GZipStream(fileStream, CompressionMode.Decompress)) { using (var memStream = new MemoryStream()) { await gzipStream.CopyToAsync(memStream); memStream.Position = 0; using (var archive = SharpCompress.Archive.Tar.TarArchive.Open(memStream)) { foreach (var entry in archive.Entries.ToList()) { if (!entry.IsDirectory && entry.Key.EndsWith(".json")) { var outputFileName = $"{dataDir.FullName}\\{entry.Key.Substring(2)}"; Console.WriteLine($"Extracting {outputFileName}"); var outputFile = new FileInfo(outputFileName); using (var outputStream = outputFile.OpenWrite()) { using (var entryStream = entry.OpenEntryStream()) { await entryStream.CopyToAsync(outputStream); } } } } } Console.WriteLine($"Opened file {fileinfo.FullName}"); } } ```
claunia commented 2026-01-29 22:06:15 +00:00
Author
Owner
Copy Link

@matthewDDennis commented on GitHub (Jan 18, 2016):

A quick look at the code shows that TarArchive.Entries is using yield. Thus, it will allow the Stream to be repositioned between each Entry causing the reading of the headers to fail due to the position change.

@matthewDDennis commented on GitHub (Jan 18, 2016): A quick look at the code shows that `TarArchive.Entries` is using `yield`. Thus, it will allow the `Stream` to be repositioned between each `Entry` causing the reading of the headers to fail due to the position change.
claunia commented 2026-01-29 22:06:15 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Jan 19, 2016):

Is this only an issue if you use CopyToAsync? I haven't looked at the code just yet but your statement seems to imply that.

I hope not. Otherwise, the bug might be more serious :)

@adamhathcock commented on GitHub (Jan 19, 2016): Is this only an issue if you use CopyToAsync? I haven't looked at the code just yet but your statement seems to imply that. I hope not. Otherwise, the bug might be more serious :)
claunia commented 2026-01-29 22:06:15 +00:00
Author
Owner
Copy Link

@iamcarbon commented on GitHub (Jun 22, 2017):

Ran into this as well. Creating an array form the entries before enumerating solved the problem.

@iamcarbon commented on GitHub (Jun 22, 2017): Ran into this as well. Creating an array form the entries before enumerating solved the problem.
claunia commented 2026-01-29 22:06:16 +00:00
Author
Owner
Copy Link

@Eli-Black-Work commented on GitHub (Sep 6, 2019):

I'm seeing this as well, but after calling OpenEntryStream().ReadAsync() on an entry while iterating through TarArchive.Entries

iamcarbon's fix worked; thanks :)

@Eli-Black-Work commented on GitHub (Sep 6, 2019): I'm seeing this as well, but after calling OpenEntryStream().ReadAsync() on an entry while iterating through TarArchive.Entries iamcarbon's fix worked; thanks :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#77
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?