starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #7] [MERGED] We need support for SFX archives #781

New Issue
Closed
opened 2026-01-29 22:17:33 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:17:33 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/7
Author: @KOLANICH
Created: 10/13/2013
Status: ✅ Merged
Merged: 10/19/2013
Merged by: @adamhathcock

Base: master ← Head: master

📝 Commits (1)

  • 13ef1c3 added test for SFX 7z archive (and partly implemented the feature, but we still have problems)

📊 Changes

7 files changed (+73 additions, -26 deletions)

View changed files

📝 SharpCompress.Test/SevenZip/SevenZipArchiveTests.cs (+11 -0)
📝 SharpCompress.Test/TestBase.cs (+25 -7)
📝 SharpCompress/Archive/ArchiveFactory.cs (+5 -3)
📝 SharpCompress/Archive/SevenZip/SevenZipArchive.cs (+22 -8)
📝 SharpCompress/AssemblyInfo.cs (+2 -2)
📝 SharpCompress/Common/SevenZip/ArchiveReader.cs (+8 -6)
➕ TestArchives/Archives/7Zip.LZMA2.sfx.exe (+0 -0)

📄 Description

Hello. I need to extract SFX with it. I have made a test for it and tried to implement it.
I have added a search for a signature (naive, but maybe it will be better to implement some better algorithm) and then i had problems.
The first one is that there is some difference between SFX and not-sfx archive which cause headers and hashsumm corruption.
The second one is that the architecture of this library is a bit strange, so it will be good to change it.
For example we can use Builder pattern : divide the process into generic stages such as finding a signature and recognizing the type using it is the one stage, reading header is another, ... etc.
Because EVERY type of archive can be made sfx or embedded into JPEG.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/7 **Author:** [@KOLANICH](https://github.com/KOLANICH) **Created:** 10/13/2013 **Status:** ✅ Merged **Merged:** 10/19/2013 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`13ef1c3`](https://github.com/adamhathcock/sharpcompress/commit/13ef1c370185e6e68a0956d1e551c207e0ed944d) added test for SFX 7z archive (and partly implemented the feature, but we still have problems) ### 📊 Changes **7 files changed** (+73 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `SharpCompress.Test/SevenZip/SevenZipArchiveTests.cs` (+11 -0) 📝 `SharpCompress.Test/TestBase.cs` (+25 -7) 📝 `SharpCompress/Archive/ArchiveFactory.cs` (+5 -3) 📝 `SharpCompress/Archive/SevenZip/SevenZipArchive.cs` (+22 -8) 📝 `SharpCompress/AssemblyInfo.cs` (+2 -2) 📝 `SharpCompress/Common/SevenZip/ArchiveReader.cs` (+8 -6) ➕ `TestArchives/Archives/7Zip.LZMA2.sfx.exe` (+0 -0) </details> ### 📄 Description Hello. I need to extract SFX with it. I have made a test for it and tried to implement it. I have added a search for a signature (naive, but maybe it will be better to implement some better algorithm) and then i had problems. The first one is that there is some difference between SFX and not-sfx archive which cause headers and hashsumm corruption. The second one is that the architecture of this library is a bit strange, so it will be good to change it. For example we can use Builder pattern : divide the process into generic stages such as finding a signature and recognizing the type using it is the one stage, reading header is another, ... etc. Because EVERY type of archive can be made sfx or embedded into JPEG. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:17:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#781
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?