starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #104] [MERGED] Fix VS2013 compiler warnings (errors) #838

New Issue
Open
opened 2026-01-29 22:17:48 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:17:48 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/104
Author: @benshoof
Created: 12/15/2015
Status: ✅ Merged
Merged: 12/15/2015
Merged by: @adamhathcock

Base: master ← Head: fix-vs2013-build

📝 Commits (1)

  • cc2ad7d Fix VS2013 compiler warnings (errors)

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 SharpCompress/Compressor/Deflate/DeflateManager.cs (+6 -6)

📄 Description

Fixes broken build in VS2013 introduced by
18bd810228. That commit attempted to fix a
compiler warning from VS2015, but this turns out to be a compiler bug:
https://github.com/dotnet/roslyn/issues/4027 . That commit added code
which VS2013 correctly treats as a compiler warning, breaking the VS2013
build.
I have reverted this unnecessary change to the deflate code, fixing the
VS2013 build, and disabled warning CS0675 on send_bits() which will
satisfy VS2015.

Fixes https://github.com/adamhathcock/sharpcompress/issues/79

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/104 **Author:** [@benshoof](https://github.com/benshoof) **Created:** 12/15/2015 **Status:** ✅ Merged **Merged:** 12/15/2015 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `fix-vs2013-build` --- ### 📝 Commits (1) - [`cc2ad7d`](https://github.com/adamhathcock/sharpcompress/commit/cc2ad7d8d5b5d0e8a4c531fcd73e9909dc960ed6) Fix VS2013 compiler warnings (errors) ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `SharpCompress/Compressor/Deflate/DeflateManager.cs` (+6 -6) </details> ### 📄 Description Fixes broken build in VS2013 introduced by 18bd8102281c04c7eb09ecfdd984d7382b629f2c. That commit attempted to fix a compiler warning from VS2015, but this turns out to be a compiler bug: https://github.com/dotnet/roslyn/issues/4027 . That commit added code which VS2013 correctly treats as a compiler warning, breaking the VS2013 build. I have reverted this unnecessary change to the deflate code, fixing the VS2013 build, and disabled warning CS0675 on send_bits() which will satisfy VS2015. Fixes https://github.com/adamhathcock/sharpcompress/issues/79 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:17:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#838
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?