starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-09 21:24:08 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #104] Fix VS2013 compiler warnings (errors) #841

New Issue
Closed
opened 2026-01-29 22:17:48 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:17:48 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/104

State: closed
Merged: Yes

Fixes broken build in VS2013 introduced by
18bd810228. That commit attempted to fix a
compiler warning from VS2015, but this turns out to be a compiler bug:
https://github.com/dotnet/roslyn/issues/4027 . That commit added code
which VS2013 correctly treats as a compiler warning, breaking the VS2013
build.
I have reverted this unnecessary change to the deflate code, fixing the
VS2013 build, and disabled warning CS0675 on send_bits() which will
satisfy VS2015.

Fixes https://github.com/adamhathcock/sharpcompress/issues/79

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/104 **State:** closed **Merged:** Yes --- Fixes broken build in VS2013 introduced by 18bd8102281c04c7eb09ecfdd984d7382b629f2c. That commit attempted to fix a compiler warning from VS2015, but this turns out to be a compiler bug: https://github.com/dotnet/roslyn/issues/4027 . That commit added code which VS2013 correctly treats as a compiler warning, breaking the VS2013 build. I have reverted this unnecessary change to the deflate code, fixing the VS2013 build, and disabled warning CS0675 on send_bits() which will satisfy VS2015. Fixes https://github.com/adamhathcock/sharpcompress/issues/79
claunia added the pull-request label 2026-01-29 22:17:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#841
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?