starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-08 21:21:57 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #121] [MERGED] Fix false positives in Rar file detection #847

New Issue
Open
opened 2026-01-29 22:17:51 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:17:51 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/121
Author: @benshoof
Created: 1/25/2016
Status: ✅ Merged
Merged: 1/26/2016
Merged by: @adamhathcock

Base: master ← Head: rar_detection_fix

📝 Commits (1)

  • e5ab9dc Fix false positives in Rar file detection

📊 Changes

6 files changed (+35 additions, -49 deletions)

View changed files

📝 SharpCompress.Test/Tar/TarArchiveTests.cs (+11 -0)
📝 SharpCompress.Test/Tar/TarReaderTests.cs (+12 -0)
📝 SharpCompress/Archive/ArchiveFactory.cs (+2 -2)
📝 SharpCompress/Archive/Rar/RarArchive.cs (+2 -6)
📝 SharpCompress/Common/Rar/Headers/MarkHeader.cs (+8 -41)
➕ TestArchives/Archives/Tar.ContainsRar.tar (+0 -0)

📄 Description

Fixes https://github.com/adamhathcock/sharpcompress/issues/117

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/121 **Author:** [@benshoof](https://github.com/benshoof) **Created:** 1/25/2016 **Status:** ✅ Merged **Merged:** 1/26/2016 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `rar_detection_fix` --- ### 📝 Commits (1) - [`e5ab9dc`](https://github.com/adamhathcock/sharpcompress/commit/e5ab9dc8832ce0695b8fb6d9d687353e05fe74d7) Fix false positives in Rar file detection ### 📊 Changes **6 files changed** (+35 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `SharpCompress.Test/Tar/TarArchiveTests.cs` (+11 -0) 📝 `SharpCompress.Test/Tar/TarReaderTests.cs` (+12 -0) 📝 `SharpCompress/Archive/ArchiveFactory.cs` (+2 -2) 📝 `SharpCompress/Archive/Rar/RarArchive.cs` (+2 -6) 📝 `SharpCompress/Common/Rar/Headers/MarkHeader.cs` (+8 -41) ➕ `TestArchives/Archives/Tar.ContainsRar.tar` (+0 -0) </details> ### 📄 Description Fixes https://github.com/adamhathcock/sharpcompress/issues/117 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:17:51 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#847
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?