starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-08 13:34:57 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #123] [MERGED] Fix various warnings #852

New Issue
Open
opened 2026-01-29 22:17:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:17:52 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/123
Author: @kenkendk
Created: 1/26/2016
Status: ✅ Merged
Merged: 1/26/2016
Merged by: @adamhathcock

Base: master ← Head: remove_warnings

📝 Commits (3)

  • 7b91b6e Commented out various unused fields that cause warnings and makes the WarningsAsErrors directive abort the build
  • 08b899f Deleted unused variables
  • f20274a Removed debug comments

📊 Changes

5 files changed (+0 additions, -19 deletions)

View changed files

📝 SharpCompress/Archive/Rar/FileInfoRarFilePart.cs (+0 -3)
📝 SharpCompress/Common/GZip/GZipVolume.cs (+0 -5)
📝 SharpCompress/Common/SevenZip/ArchiveReader.cs (+0 -7)
📝 SharpCompress/Common/SevenZip/DataReader.cs (+0 -2)
📝 SharpCompress/Compressor/LZMA/Bcj2DecoderStream.cs (+0 -2)

📄 Description

When building the solution with Xamarin Studio on OSX, it complains about a number of unused fields and variables.

Commenting these out has no ill effect. I can make an update with the fields deleted if you like.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/123 **Author:** [@kenkendk](https://github.com/kenkendk) **Created:** 1/26/2016 **Status:** ✅ Merged **Merged:** 1/26/2016 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `remove_warnings` --- ### 📝 Commits (3) - [`7b91b6e`](https://github.com/adamhathcock/sharpcompress/commit/7b91b6e7c8528f2d76374cfc5cfb532a75ef5cf5) Commented out various unused fields that cause warnings and makes the WarningsAsErrors directive abort the build - [`08b899f`](https://github.com/adamhathcock/sharpcompress/commit/08b899fdac28492ced6c237200020598f013a229) Deleted unused variables - [`f20274a`](https://github.com/adamhathcock/sharpcompress/commit/f20274aac7a9bd5f45bb8bed771289bfe8dc93ed) Removed debug comments ### 📊 Changes **5 files changed** (+0 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `SharpCompress/Archive/Rar/FileInfoRarFilePart.cs` (+0 -3) 📝 `SharpCompress/Common/GZip/GZipVolume.cs` (+0 -5) 📝 `SharpCompress/Common/SevenZip/ArchiveReader.cs` (+0 -7) 📝 `SharpCompress/Common/SevenZip/DataReader.cs` (+0 -2) 📝 `SharpCompress/Compressor/LZMA/Bcj2DecoderStream.cs` (+0 -2) </details> ### 📄 Description When building the solution with Xamarin Studio on OSX, it complains about a number of unused fields and variables. Commenting these out has no ill effect. I can make an update with the fields deleted if you like. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:17:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#852
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?