starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #131] Fix IsRarFile() StreamingMode #859

New Issue
Open
opened 2026-01-29 22:17:54 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:17:54 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/131
Author: @benshoof
Created: 2/18/2016
Status: 🔄 Open

Base: master ← Head: fix-rar-streamingmode

📝 Commits (1)

  • f0b4d04 Fix IsRarFile() StreamingMode

📊 Changes

4 files changed (+11 additions, -5 deletions)

View changed files

📝 SharpCompress/Archive/ArchiveFactory.cs (+3 -2)
📝 SharpCompress/Archive/Rar/RarArchive.cs (+6 -1)
📝 SharpCompress/IO/StreamingMode.cs (+1 -1)
📝 SharpCompress/Reader/ReaderFactory.cs (+1 -1)

📄 Description

IsRarFile() no longer assumes seekable stream. This caused IsRarFile()
to break RewindableStreams when testing certain files, causing
ReaderFactory to fail to open certain tars.

Fixes https://github.com/adamhathcock/sharpcompress/issues/130

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/131 **Author:** [@benshoof](https://github.com/benshoof) **Created:** 2/18/2016 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-rar-streamingmode` --- ### 📝 Commits (1) - [`f0b4d04`](https://github.com/adamhathcock/sharpcompress/commit/f0b4d04685b1a8fd978f33d01da8d35243fea43d) Fix IsRarFile() StreamingMode ### 📊 Changes **4 files changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `SharpCompress/Archive/ArchiveFactory.cs` (+3 -2) 📝 `SharpCompress/Archive/Rar/RarArchive.cs` (+6 -1) 📝 `SharpCompress/IO/StreamingMode.cs` (+1 -1) 📝 `SharpCompress/Reader/ReaderFactory.cs` (+1 -1) </details> ### 📄 Description IsRarFile() no longer assumes seekable stream. This caused IsRarFile() to break RewindableStreams when testing certain files, causing ReaderFactory to fail to open certain tars. Fixes https://github.com/adamhathcock/sharpcompress/issues/130 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:17:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#859
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?