starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

SharpCompress unable to unzip few tar.gz #87

New Issue
Closed
opened 2026-01-29 22:06:23 +00:00 by claunia · 7 comments
claunia commented 2026-01-29 22:06:23 +00:00
Owner
Copy Link

Originally created by @HrishikeshSingh on GitHub (Feb 16, 2016).

I am using SharpCompress nuget package to unzip files.
There are few files that SharpCompress is unable to unzip.
You can get the file from the link https://github.com/isagalaev/highlight.js/archive/8.9.1.tar.gz

Below is the exception that I am getting:

System.ArgumentNullException was unhandled
HResult=-2147467261
Message=Value cannot be null.
Parameter name: path2
ParamName=path2
Source=mscorlib
StackTrace:
at System.IO.Path.Combine(String path1, String path2)
at SharpCompress.Reader.IReaderExtensions.WriteEntryToDirectory(IReader reader, String destinationDirectory, ExtractOptions options)
at Sharpcompress.Program.Main(String[] args) in E:\2015Projects\Sharpcompress\Program.cs:line 24
at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()
InnerException:

The code used to unzip is

        string filePath = @"E:\drop\highlight.js-8.9.1.tar.gz";
         using (Stream stream = File.OpenRead(filePath))
         {
             var reader = ReaderFactory.Open(stream);
             while (reader.MoveToNextEntry())
             {
                 if (!reader.Entry.IsDirectory)
                 {
                     reader.WriteEntryToDirectory(@"E:\drop\archive", ExtractOptions.ExtractFullPath | ExtractOptions.Overwrite);
                 }
             }
         }
Originally created by @HrishikeshSingh on GitHub (Feb 16, 2016). I am using SharpCompress nuget package to unzip files. There are few files that SharpCompress is unable to unzip. You can get the file from the link https://github.com/isagalaev/highlight.js/archive/8.9.1.tar.gz **Below is the exception that I am getting:** System.ArgumentNullException was unhandled HResult=-2147467261 Message=Value cannot be null. Parameter name: path2 ParamName=path2 Source=mscorlib StackTrace: at System.IO.Path.Combine(String path1, String path2) at SharpCompress.Reader.IReaderExtensions.WriteEntryToDirectory(IReader reader, String destinationDirectory, ExtractOptions options) at Sharpcompress.Program.Main(String[] args) in E:\2015Projects\Sharpcompress\Program.cs:line 24 at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args) at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args) at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly() at System.Threading.ThreadHelper.ThreadStart_Context(Object state) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() InnerException: The code used to unzip is ``` string filePath = @"E:\drop\highlight.js-8.9.1.tar.gz"; using (Stream stream = File.OpenRead(filePath)) { var reader = ReaderFactory.Open(stream); while (reader.MoveToNextEntry()) { if (!reader.Entry.IsDirectory) { reader.WriteEntryToDirectory(@"E:\drop\archive", ExtractOptions.ExtractFullPath | ExtractOptions.Overwrite); } } } ```
claunia commented 2026-01-29 22:06:23 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Feb 16, 2016):

Looks like an entry in the tar has a weird or invalid name that SharpCompress isn't handling.

If you could debug further that would be great.

@adamhathcock commented on GitHub (Feb 16, 2016): Looks like an entry in the tar has a weird or invalid name that SharpCompress isn't handling. If you could debug further that would be great.
claunia commented 2026-01-29 22:06:23 +00:00
Author
Owner
Copy Link

@HrishikeshSingh commented on GitHub (Feb 16, 2016):

This issue is repro-able with any tar.gz file that i download from github.
Way to download. Go to release tab. Download tar.gz file of any of the releases and then try to uncompress it. It will always fail if any tar.gz is downloaded from GitHub. Invalid or weird cannot happen for all. Either Github is adding something extra which is not handled in SharpCompress.
I also tried using SharpZipLib nupkg and that works fine, but there is some license issue with that so wanted to use SharpCompress. Could not figure out what was wrong.

@HrishikeshSingh commented on GitHub (Feb 16, 2016): This issue is repro-able with any tar.gz file that i download from github. Way to download. Go to release tab. Download tar.gz file of any of the releases and then try to uncompress it. It will always fail if any tar.gz is downloaded from GitHub. Invalid or weird cannot happen for all. Either Github is adding something extra which is not handled in SharpCompress. I also tried using SharpZipLib nupkg and that works fine, but there is some license issue with that so wanted to use SharpCompress. Could not figure out what was wrong.
claunia commented 2026-01-29 22:06:24 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Feb 16, 2016):

I'm not going to have time to debug this. I'd be hardpressed to say that every tar.gz has this problem but maybe it's something my tar implementation hasn't covered that github's tar generation does.

@adamhathcock commented on GitHub (Feb 16, 2016): I'm not going to have time to debug this. I'd be hardpressed to say that every tar.gz has this problem but maybe it's something my tar implementation hasn't covered that github's tar generation does.
claunia commented 2026-01-29 22:06:24 +00:00
Author
Owner
Copy Link

@benshoof commented on GitHub (Feb 17, 2016):

Tars created by git-archive start with a tar entry with metadata about the commit they're produced from. This entry is named pax_global_header (POSIX global header) and has an entry type of 'g', which is Global Extended Header. SharpCompress doesn't recognize this entry type yet so it fails the IsTarFile() test. All that needs to be done is to add this entry type to SharpCompress.

Add this to the EntryType enum in TarHeader.cs:

GlobalExtendedHeader = (byte) 'g'

This does mean that SharpCompress will extract this entry to a file named pax_global_header so if you don't want that then you'll have to manually exclude it in your code. From the quick sampling I've done, other third party tar implementations behave the same.

While debugging this I came across a more significant SharpCompress bug that this sample archive just happened to trip. I'll write that up separately when I have the time but for now the archive should just work once GlobalExtendedHeader is defined.

@benshoof commented on GitHub (Feb 17, 2016): Tars created by git-archive start with a tar entry with metadata about the commit they're produced from. This entry is named pax_global_header (POSIX global header) and has an entry type of 'g', which is Global Extended Header. SharpCompress doesn't recognize this entry type yet so it fails the IsTarFile() test. All that needs to be done is to add this entry type to SharpCompress. Add this to the EntryType enum in TarHeader.cs: `GlobalExtendedHeader = (byte) 'g'` This does mean that SharpCompress will extract this entry to a file named pax_global_header so if you don't want that then you'll have to manually exclude it in your code. From the quick sampling I've done, other third party tar implementations behave the same. While debugging this I came across a more significant SharpCompress bug that this sample archive just happened to trip. I'll write that up separately when I have the time but for now the archive should just work once GlobalExtendedHeader is defined.
claunia commented 2026-01-29 22:06:24 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Feb 17, 2016):

Thanks for the info. You rule :)

@adamhathcock commented on GitHub (Feb 17, 2016): Thanks for the info. You rule :)
claunia commented 2026-01-29 22:06:24 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Feb 17, 2016):

To be a bit more accurate: thanks for the research :)

I know the tar implementation is not robust and I ought to find another or recode it. Anything you find is good info. Thanks again.

@adamhathcock commented on GitHub (Feb 17, 2016): To be a bit more accurate: thanks for the research :) I know the tar implementation is not robust and I ought to find another or recode it. Anything you find is good info. Thanks again.
claunia commented 2026-01-29 22:06:25 +00:00
Author
Owner
Copy Link

@HrishikeshSingh commented on GitHub (Feb 18, 2016):

By when can i expect the fix rolled out.

@HrishikeshSingh commented on GitHub (Feb 18, 2016): By when can i expect the fix rolled out.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#87
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?