starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-08 05:27:04 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #188] [MERGED] Fix null password on ReaderFactory. Fix null options on SevenZipArchive #887

New Issue
Closed
opened 2026-01-29 22:18:03 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:03 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/188
Author: @adamhathcock
Created: 10/3/2016
Status: ✅ Merged
Merged: 10/3/2016
Merged by: @adamhathcock

Base: master ← Head: fix_nulls

📝 Commits (2)

  • f26ba91 Fix null password on ReaderFactory. Fix null options on SevenZipArchive
  • d7e29f7 Fix occasionally failing test

📊 Changes

5 files changed (+10 additions, -6 deletions)

View changed files

📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+2 -2)
📝 src/SharpCompress/Common/Volume.cs (+2 -2)
📝 src/SharpCompress/Readers/AbstractReader.cs (+1 -1)
📝 src/SharpCompress/Readers/ReaderFactory.cs (+1 -1)
📝 test/SharpCompress.Test/Zip/ZipReaderTests.cs (+4 -0)

📄 Description

Fix for https://github.com/adamhathcock/sharpcompress/issues/187

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/188 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 10/3/2016 **Status:** ✅ Merged **Merged:** 10/3/2016 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `fix_nulls` --- ### 📝 Commits (2) - [`f26ba91`](https://github.com/adamhathcock/sharpcompress/commit/f26ba91386e4561db1fe21299f6c77ec8b239397) Fix null password on ReaderFactory. Fix null options on SevenZipArchive - [`d7e29f7`](https://github.com/adamhathcock/sharpcompress/commit/d7e29f7c4d8e791ac58919cfb1238841dcb61f89) Fix occasionally failing test ### 📊 Changes **5 files changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+2 -2) 📝 `src/SharpCompress/Common/Volume.cs` (+2 -2) 📝 `src/SharpCompress/Readers/AbstractReader.cs` (+1 -1) 📝 `src/SharpCompress/Readers/ReaderFactory.cs` (+1 -1) 📝 `test/SharpCompress.Test/Zip/ZipReaderTests.cs` (+4 -0) </details> ### 📄 Description Fix for https://github.com/adamhathcock/sharpcompress/issues/187 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:03 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#887
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?