starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-08 05:27:04 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #186] [CLOSED] Start using buffers. Minimal in algorithms for now. #888

New Issue
Closed
opened 2026-01-29 22:18:03 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:03 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/186
Author: @adamhathcock
Created: 10/3/2016
Status: ❌ Closed

Base: master ← Head: system_buffers

📝 Commits (6)

  • 771986c Start using buffers. Minimal in algorithms for now.
  • aa55e16 Merge branch 'master' into system_buffers
  • 4f092f4 update xunit
  • cd7e480 Dumb mistake on buffer usage
  • 3d4b190 use pool in MarkingBinaryReader and BinaryReader
  • 0dfdba3 Change more ReadBytes

📊 Changes

26 files changed (+711 additions, -452 deletions)

View changed files

📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+19 -16)
📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+4 -2)
📝 src/SharpCompress/Common/GZip/GZipFilePart.cs (+64 -57)
📝 src/SharpCompress/Common/Rar/Headers/FileHeader.cs (+54 -53)
📝 src/SharpCompress/Common/Rar/Headers/FileNameDecoder.cs (+6 -5)
📝 src/SharpCompress/Common/Rar/Headers/RarHeader.cs (+2 -1)
📝 src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs (+31 -27)
📝 src/SharpCompress/Common/Rar/RarCryptoBinaryReader.cs (+40 -15)
📝 src/SharpCompress/Common/Rar/RarCryptoWrapper.cs (+12 -7)
📝 src/SharpCompress/Common/Rar/RarRijndael.cs (+15 -12)
📝 src/SharpCompress/Common/Tar/Headers/TarHeader.cs (+54 -41)
📝 src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs (+11 -6)
📝 src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs (+7 -4)
📝 src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs (+13 -10)
📝 src/SharpCompress/Compressors/BZip2/BZip2Stream.cs (+7 -4)
📝 src/SharpCompress/Compressors/Deflate/GZipStream.cs (+58 -50)
📝 src/SharpCompress/Compressors/Deflate/ZlibBaseStream.cs (+83 -76)
📝 src/SharpCompress/Crypto/IBlockCipher.cs (+6 -6)
📝 src/SharpCompress/Crypto/RijndaelEngine.cs (+6 -9)
➕ src/SharpCompress/IO/ByteArrayPool.cs (+52 -0)

...and 6 more files

📄 Description

Covering the idea here: https://github.com/adamhathcock/sharpcompress/issues/111

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/186 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 10/3/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `system_buffers` --- ### 📝 Commits (6) - [`771986c`](https://github.com/adamhathcock/sharpcompress/commit/771986c50cedf40c77c396491e7b7e9ffce33940) Start using buffers. Minimal in algorithms for now. - [`aa55e16`](https://github.com/adamhathcock/sharpcompress/commit/aa55e1643cd8aeed1d7e70a91ad2fdc6ec822784) Merge branch 'master' into system_buffers - [`4f092f4`](https://github.com/adamhathcock/sharpcompress/commit/4f092f4c4489294d293148a62d5620369b544b5c) update xunit - [`cd7e480`](https://github.com/adamhathcock/sharpcompress/commit/cd7e480e5136e4b9123a6bf9bebfd680d67ea6e0) Dumb mistake on buffer usage - [`3d4b190`](https://github.com/adamhathcock/sharpcompress/commit/3d4b1904ca6a1bc32692888a178864d0ad0dbb04) use pool in MarkingBinaryReader and BinaryReader - [`0dfdba3`](https://github.com/adamhathcock/sharpcompress/commit/0dfdba3ea122f99c2ee44082ebd0847dc345fff8) Change more ReadBytes ### 📊 Changes **26 files changed** (+711 additions, -452 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+19 -16) 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+4 -2) 📝 `src/SharpCompress/Common/GZip/GZipFilePart.cs` (+64 -57) 📝 `src/SharpCompress/Common/Rar/Headers/FileHeader.cs` (+54 -53) 📝 `src/SharpCompress/Common/Rar/Headers/FileNameDecoder.cs` (+6 -5) 📝 `src/SharpCompress/Common/Rar/Headers/RarHeader.cs` (+2 -1) 📝 `src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs` (+31 -27) 📝 `src/SharpCompress/Common/Rar/RarCryptoBinaryReader.cs` (+40 -15) 📝 `src/SharpCompress/Common/Rar/RarCryptoWrapper.cs` (+12 -7) 📝 `src/SharpCompress/Common/Rar/RarRijndael.cs` (+15 -12) 📝 `src/SharpCompress/Common/Tar/Headers/TarHeader.cs` (+54 -41) 📝 `src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs` (+11 -6) 📝 `src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs` (+7 -4) 📝 `src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs` (+13 -10) 📝 `src/SharpCompress/Compressors/BZip2/BZip2Stream.cs` (+7 -4) 📝 `src/SharpCompress/Compressors/Deflate/GZipStream.cs` (+58 -50) 📝 `src/SharpCompress/Compressors/Deflate/ZlibBaseStream.cs` (+83 -76) 📝 `src/SharpCompress/Crypto/IBlockCipher.cs` (+6 -6) 📝 `src/SharpCompress/Crypto/RijndaelEngine.cs` (+6 -9) ➕ `src/SharpCompress/IO/ByteArrayPool.cs` (+52 -0) _...and 6 more files_ </details> ### 📄 Description Covering the idea here: https://github.com/adamhathcock/sharpcompress/issues/111 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:03 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#888
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?