starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #210] [MERGED] Fix invalid headers #901

New Issue
Closed
opened 2026-01-29 22:18:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/210
Author: @kenkendk
Created: 3/9/2017
Status: ✅ Merged
Merged: 3/9/2017
Merged by: @adamhathcock

Base: master ← Head: fix_invalid_headers

📝 Commits (2)

  • 6ef3be4 Fixed writing correct headers in zip archives
  • 81ab5c1 Fixed writing correct headers in zip archives

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs (+2 -2)
📝 src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs (+2 -2)

📄 Description

This fixes a bug introduced with 6be6ef0b5c.

Bad news is that all zip files written with 0.15.1 are semi-broken.
That is, their filenames are garbled, but content is recoverable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/210 **Author:** [@kenkendk](https://github.com/kenkendk) **Created:** 3/9/2017 **Status:** ✅ Merged **Merged:** 3/9/2017 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `fix_invalid_headers` --- ### 📝 Commits (2) - [`6ef3be4`](https://github.com/adamhathcock/sharpcompress/commit/6ef3be4b5cd42ae391768b4360b00778f7e42094) Fixed writing correct headers in zip archives - [`81ab5c1`](https://github.com/adamhathcock/sharpcompress/commit/81ab5c189db2f83ed56d03157b9f0b6aae2affeb) Fixed writing correct headers in zip archives ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs` (+2 -2) 📝 `src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs` (+2 -2) </details> ### 📄 Description This fixes a bug introduced with 6be6ef0b5c3ed6a4d40d00c8fb133518e75e4a6f. Bad news is that all zip files written with 0.15.1 are semi-broken. That is, their filenames are garbled, but content is recoverable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#901
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?